DEP PHP8 support #867
Merged
DEP PHP8 support #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@emteknetnz, I reran the tests and the PHP8 travis tests are now passing, any reason why we shouldn't merge this? I've seen projects having to fork this module to get it running with PHP8 and avoid the composer constraint - even though there are no failures explicitly with this module. We still have #866 which can stay open until the remaining tasks are done? |
|
I've lost context on where the php8 work go to. It's probably OK to merge this, we have the equivalent constraint within framework https://github.com/silverstripe/silverstripe-framework/blob/4/composer.json#L42 |
brynwhyman
approved these changes
Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.