Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP8 support #866

Closed
emteknetnz opened this issue Jan 20, 2021 · 7 comments
Closed

PHP8 support #866

emteknetnz opened this issue Jan 20, 2021 · 7 comments
Assignees
@maxime-rainville
Labels
affects/v4 complexity/medium impact/high type/enhancement

Comments

@emteknetnz
Copy link
Member

emteknetnz commented Jan 20, 2021 •
edited by brynwhyman
Loading

ACs

  • Ensure that silverstripe/elemental works with PHP8
  • Update composer.json to allow PHP8 installation e.g. "php": "^7.1 || ^8.0" (PR: DEP PHP8 support #867)
  • Ensure that this ENH Disable actions users does not have permissions for #874 and any other high impact bug fixes targeting next-minor 4 are also merged before tagging
  • Tag 4.6.0 which also includes graphql4 support
  • Ensure the folowing elemental modules are also PHP8 compatible and installable:
    • silverstripe/elemental-fileblock
    • silverstripe/elemental-bannerblock
    • dnadesign/silverstripe-elemental-userforms
    • dnadesign/silverstripe-elemental-subsites
  • Run through manual regression test suite for elemental
  • Consider a module release following the work
@brynwhyman brynwhyman mentioned this issue Mar 18, 2021
Closed
1 task
@brynwhyman brynwhyman mentioned this issue May 11, 2021
Merged
@obj63mc
Copy link

obj63mc commented Jun 30, 2021

Was looking to update a few of my sites to php8 and with 4.6.0 released currently it seems that only Silverstripe Elemental is the only module not fully supporting php8 yet. v4.3.2 works great with php8 so assuming its more the changes to graphql4 that need attention. Just wondering if this is on the roadmap this year or what can be done to help get this over the line

@emteknetnz
Copy link
Member Author

emteknetnz commented Jun 30, 2021 •
edited
Loading

I don't believe GraphQL 4 is a blocker in regards to PHP8 support.

We're aiming to get PHP8 support across the board for modules that Silverstripe Ltd supports later this year. Currently most things should work fine with PHP8, though not everything. We haven't announced official support yet.

@tractorcow
Copy link
Contributor

4.6.0 broke compatibility with graphql 3 (see #870), now that graphql typeNames map is no longer respected. Can you update the composer dependencies to reflect that?

graphql 3 users upgrading their silverstripe versions will need to lock to ~4.5.0 of elemental.

@emteknetnz
Copy link
Member Author

OK that wasn't supposed to happen, elemental 4.6.0 should work on both versions of graphql. Thanks for pointing this out.

@brynwhyman brynwhyman changed the title PHP8 support, tag 4.6.0 + other elemental modules PHP8 support Jul 11, 2021
@brynwhyman brynwhyman mentioned this issue Sep 15, 2021
Merged
@emteknetnz emteknetnz self-assigned this Oct 27, 2021
@emteknetnz
Copy link
Member Author

banner-block should be sorted by this silverstripe/silverstripe-elemental-bannerblock#78 (comment)

@emteknetnz emteknetnz removed their assignment Oct 28, 2021
@maxime-rainville maxime-rainville self-assigned this Nov 4, 2021
@emteknetnz
Copy link
Member Author

emteknetnz commented Nov 10, 2021 •
edited
Loading

Graphql3 breaking 4.6.0 convo - #870
PR (merged) #912

@maxime-rainville
Copy link
Contributor

There's nothing left to do on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maxime-rainville maxime-rainville

Labels
affects/v4 complexity/medium impact/high type/enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@obj63mc @tractorcow @maxime-rainville @emteknetnz