Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API phpunit 9 support #78

Merged
merged 1 commit into from
Nov 8, 2021
Merged

API phpunit 9 support #78

merged 1 commit into from
Nov 8, 2021

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz marked this pull request as draft October 12, 2021 02:59
@emteknetnz emteknetnz mentioned this pull request Oct 12, 2021
Closed
93 tasks
@emteknetnz emteknetnz force-pushed the pulls/2/sapphire-test-nine branch 5 times, most recently from ed3119c to 6134d3d Compare October 21, 2021 21:50
@emteknetnz
Copy link
Member Author

Travis failure in php 8.0 is existing

@emteknetnz emteknetnz marked this pull request as ready for review October 22, 2021 01:00
@emteknetnz emteknetnz force-pushed the pulls/2/sapphire-test-nine branch 2 times, most recently from 0a27233 to d97d809 Compare October 27, 2021 05:23
@maxime-rainville maxime-rainville mentioned this pull request Oct 28, 2021
Merged
@maxime-rainville
Copy link

This PR should fix the PHP8 build: silverstripe/silverstripe-event-dispatcher#17

@emteknetnz emteknetnz mentioned this pull request Oct 28, 2021
Closed
@maxime-rainville
Copy link

The other PR got merged and I tagged a new release ... however there's some other things that broke in-between I think

@emteknetnz emteknetnz force-pushed the pulls/2/sapphire-test-nine branch 2 times, most recently from f9fff96 to c4f5077 Compare November 1, 2021 03:27
maxime-rainville
maxime-rainville requested changes Nov 2, 2021
View reviewed changes
Copy link

@maxime-rainville maxime-rainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The the 2 build failures appear to be related to the PHPUnit9 upgrade.
image

@emteknetnz emteknetnz force-pushed the pulls/2/sapphire-test-nine branch from c4f5077 to 65c4367 Compare November 3, 2021 22:00
@emteknetnz emteknetnz force-pushed the pulls/2/sapphire-test-nine branch from 65c4367 to c813dd4 Compare November 4, 2021 03:27
maxime-rainville
maxime-rainville approved these changes Nov 8, 2021
View reviewed changes
Copy link

@maxime-rainville maxime-rainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxime-rainville maxime-rainville merged commit 5ae1f78 into silverstripe:2 Nov 8, 2021
@maxime-rainville maxime-rainville deleted the pulls/2/sapphire-test-nine branch November 8, 2021 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxime-rainville maxime-rainville maxime-rainville approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @maxime-rainville