Update form styles in CMS when editing Elements #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fields in e.g. 'split mode' editing within the CMS looked a bit squished as the labels first took up an amount of room to the left of the field proper. The better and desired approach here was to use the .stacked class - rendering the labels atop the field. However this approach would require every element built to add the extraClass to the FormField instance in PHP in the getCMSFields method. This is less than ideal, so it was decided to proceed with an override for elements (and elements only) that will achieve the same effect. Also addresses checkboxes and radio buttons where the label generally sits on the other side of the input element, where .stacked does not.
ScopeyNZ
approved these changes
Oct 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fields in e.g. 'split mode' editing within the CMS looked a bit
squished as the labels first took up an amount of room to the left of
the field proper. The better and desired approach here was to use the
.stacked class - rendering the labels atop the field.
However this approach would require every element built to add the
extraClass to the FormField instance in PHP in the getCMSFields method.
This is less than ideal, so it was decided to proceed with an override
for elements (and elements only) that will achieve the same effect.
Resolves #388