Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update styling on in-line forms #388

Closed
ScopeyNZ opened this issue Sep 13, 2018 · 9 comments
Closed

Update styling on in-line forms #388

ScopeyNZ opened this issue Sep 13, 2018 · 9 comments

Comments

@ScopeyNZ
Copy link
Contributor

ScopeyNZ commented Sep 13, 2018

Couple of design notes for the new in-line edit forms:

  • Fields should be using the "stacked" mode. Labels should appear above inputs. This can be done by adding the stacked class to the form-group container:

Old:
image

New:
image

  • Responsive min-width should be updated. Specifically for TinyMCE that's looking a little cramped:

image

  • In-line edit form has horizontal scroll:

image

  • When in edit mode with a reduced window width the TinyMCE right border is lost:
    image.png

Add it here if there was anything I missed (cc @clarkepaul - let me know if you want to run through this together in more detail).

@clarkepaul
Copy link

Apart from making the editor area bigger we'll need to create a separate issue to organise the TinyMCE options.

@brynwhyman
Copy link

brynwhyman commented Sep 30, 2018

At least the above two points appear to be inherited from core styling. See here for details silverstripe/silverstripe-admin#655

@brynwhyman
Copy link

I'm changing this to impact/medium.

@brynwhyman brynwhyman added this to the Sprint 23 milestone Oct 17, 2018
@raissanorth raissanorth self-assigned this Oct 26, 2018
@raissanorth
Copy link
Contributor

It appears that the first point has already been actioned upon.

See wide screen size:

image

See narrow screen size:

image

@raissanorth
Copy link
Contributor

There are some weird semi-states as well... 🤔

image

@raissanorth raissanorth removed their assignment Oct 26, 2018
@NightJar NightJar self-assigned this Oct 28, 2018
@clarkepaul
Copy link

If this hasn't been fixed, can we make sure there is an issue to capture it (or let me know to capture it), it should nicely for smaller sizes.
image

@NightJar
Copy link
Contributor

Closed in #478

@brynwhyman
Copy link

If this hasn't been fixed, can we make sure there is an issue to capture it (or let me know to capture it), it should nicely for smaller sizes.

@clarkepaul this wasn't fixed by this PR. I've raised #483 to track it.

@NightJar
Copy link
Contributor

It was a run-on effect of the scrollbar and styling issues addressed in #478 and #487 respectively

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants