You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It was talked about how these are default styles inherited from the CMS as a whole, and are a sort of run on from being implemented via media queries - which are relative to a the viewport size, rather than the size of the containing element.
However as we move towards an entirely React run interface, the component react-resize-aware is a good solution we've discovered with @raissanorth working on #560, and this should be an entirely possible solution now.
e.g.
vs
The context here being "Inline Editing" with Elemental.
Making a change to allow forms to adjust their layout according to their containing element's size would be much more ideal as we move towards forms hosting other forms, or even just interactive components in smaller spaces (while the viewport is still relatively large).
We've come across react-resize-aware before, and it doesn't work in FF. See @maxime-rainville summary at #595. Is what you're trying to do possible via react-resize-observer?
@NightJar Happy for your team to pick this up and fix it across all forms in core, which can then benefit the elemental inline editing use case. Can you please bring it to your PO's attention?
During demonstration of a new feature for https://github.com/dnadesign/silverstripe-elemental @chillu and @be2n pointed out that the form fields look a little cramped in small spaces.
It was talked about how these are default styles inherited from the CMS as a whole, and are a sort of run on from being implemented via media queries - which are relative to a the viewport size, rather than the size of the containing element.
However as we move towards an entirely React run interface, the component
react-resize-aware
is a good solution we've discovered with @raissanorth working on #560, and this should be an entirely possible solution now.e.g.
vs
The context here being "Inline Editing" with Elemental.
Making a change to allow forms to adjust their layout according to their containing element's size would be much more ideal as we move towards forms hosting other forms, or even just interactive components in smaller spaces (while the viewport is still relatively large).
Directly related: #653
The text was updated successfully, but these errors were encountered: