NEW All unsaved blocks on a page will now save as the page is saved #439
Conversation
|
Someone might be able to provide a good solution to optimistic cache updates. If I can get the |
src/Forms/ElementalAreaField.php
Outdated
| public function setSubmittedValue($value, $data = null) | ||
| { | ||
| // Content comes through as a JSON encoded list through a hidden field. | ||
| $this->setValue(Convert::json2array($value)); |
There was a problem hiding this comment.
It'd be good to return $this for chaining, and also these methods could use doc blocks
src/Forms/ElementalAreaField.php
Outdated
|
|
||
| foreach ($elementData as $form => $data) { | ||
| // Extract the ID | ||
| $elementId = (int) substr($form, 12); |
ScopeyNZ
force-pushed
the
pulls/4.0/save-all-the-things
branch
2 times, most recently
from
e33f5c4 to
95e6ceb
Compare
|
Okay the Behat tests should pass once these two dependant PRs are merged: |
ScopeyNZ
changed the title
| { | ||
| $label = $block->findAll('xpath', sprintf('//label[contains(text(), \'%s\')]', $name)); | ||
|
|
||
| assertNotNull($label, sprintf('Could not find a label for a field with the content "%s"', $name)); |
There was a problem hiding this comment.
In the case of Title I get the following issue with this:
Found more than one label containing the phrase "Title". Failed asserting that actual size 0 matches expected size 1.
The HTML looks as follows:
<label for="Form_ElementForm_11_PageElements_11_Title" class="form__field-label ">Title (displayed if checked)</label>
and in the feature file I've got
And I fill in "Charlie's Block" for "Title" for block 2
There was a problem hiding this comment.
Okay, I found the mistake I made. This works as expected, but the message is wrong. Should assert the count instead.
raissanorth
force-pushed
the
pulls/4.0/save-all-the-things
branch
from
b630ed0 to
65416be
Compare
src/Forms/ElementalAreaField.php
Outdated
|
|
||
| /** | ||
| * {@inheritdoc} | ||
| */ |
There was a problem hiding this comment.
This is the same as not having a doc block at all, you may as well leave it out and save the lines
There was a problem hiding this comment.
It'd be good to return
$thisfor chaining, and also these methods could use doc blocks
😆 I'll remove them again 🙂
There was a problem hiding this comment.
Love me a transparent doc block
src/Forms/ElementalAreaField.php
Outdated
| public function setSubmittedValue($value, $data = null) | ||
| { | ||
| // Content comes through as a JSON encoded list through a hidden field. | ||
| return $this->setValue(Convert::json2array($value)); |
There was a problem hiding this comment.
FYI we've agree to deprecate these JSON handling methods, from now on we may as well just use regular PHP json methods. RFC: silverstripe/silverstripe-framework#8424
ScopeyNZ
force-pushed
the
pulls/4.0/save-all-the-things
branch
2 times, most recently
from
d575a38 to
d44fdf2
Compare
ScopeyNZ
force-pushed
the
pulls/4.0/save-all-the-things
branch
from
d44fdf2 to
474d24f
Compare
Fixes #328 . This works by syncing redux state with a hidden field. The content of the hidden field is then used to write back into the various elements within an elemental area.
Relies on silverstripe/silverstripe-admin#682
Todo: