FIX Changing the value of a TinyMCE field will correctly trigger a change in the React component #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbieaverill
approved these changes
Oct 10, 2018
3 tasks
ScopeyNZ
force-pushed
the
pulls/4.3/re-tinymce-act-events
branch
from
2d88d7e to
4702a22
Compare
3 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #676 and #654. The new React component for TinyMCE updates the redux store when it is added or removed from the DOM but not when the value is actually changed. This PR adds a proper change event to the existing jQuery "change" event that gets fired when TinyMCE content changes. React will only pick up the proper event - it ignores the jQuery one.
Excuse the branch name target - it's meant to be
1.3!