DEP Upgrade frontend build stack #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
force-pushed
the
pulls/4/frontend-build-stack
branch
from
1f3969a to
bbef191
Compare
|
unit test failure is unrelated |
GuySartorelli
commented
Jan 26, 2023
| @@ -1,8 +1,5 @@ | |||
| # Ignore dist files | |||
| client/dist/ | |||
|
|
|||
| # Ignore legacy files | |||
| client/src/legacy/ | |||
There was a problem hiding this comment.
It's not actually legacy - we're not getting rid of it any time soon so it should meet our linting standards.
GuySartorelli
force-pushed
the
pulls/4/frontend-build-stack
branch
from
bbef191 to
2e05666
Compare
GuySartorelli
changed the title
GuySartorelli
force-pushed
the
pulls/4/frontend-build-stack
branch
from
2e05666 to
3aee737
Compare
emteknetnz
requested changes
Jan 30, 2023
|
The comments form currently isn't rendering - silverstripe/silverstripe-framework#10676 needs to be merged to fix that. |
|
Email address validation also broken - silverstripe/comment-notifications#50 fixes that |
|
The error you mentioned is now fixed in the bulk editing tools PR |
emteknetnz
approved these changes
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT SQUASH - the commits in this PR are distinct.
Parent issue