Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP Upgrade frontend build stack #697

Merged

Conversation

@GuySartorelli GuySartorelli force-pushed the pulls/4/frontend-build-stack branch from 1583084 to 62809b9 Compare January 26, 2023 02:14
Copy link
Member

@emteknetnz emteknetnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing behat tests after rerun after merging other PRs

@GuySartorelli
Copy link
Member Author

I can reproduce the failures locally. Will look at them next week.

@GuySartorelli
Copy link
Member Author

GuySartorelli commented Feb 6, 2023

This failure also happens when running behat tests without this PR (if you update the feature to correctly set the categories and tags). Whatever is causing the failure, it's not caused by this PR.
The behaviour the behat test is covering does work when attempted manually and I can't quickly find what's causing the failure, so I think we should treat this in a separate broken builds issue.

@emteknetnz emteknetnz merged commit ffea8ac into silverstripe:4 Feb 7, 2023
@emteknetnz emteknetnz deleted the pulls/4/frontend-build-stack branch February 7, 2023 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants