Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH Use class name instead of self #761

Merged
merged 1 commit into from
Jun 16, 2024
Merged

ENH Use class name instead of self #761

merged 1 commit into from
Jun 16, 2024

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz mentioned this pull request Jun 5, 2024
Closed
5 tasks
@emteknetnz emteknetnz force-pushed the pulls/4.2/remove-self branch from 1f1bdad to 0a4626c Compare June 5, 2024 04:57
@emteknetnz emteknetnz force-pushed the pulls/4.2/remove-self branch from 0a4626c to 6c37e8f Compare June 14, 2024 00:32
GuySartorelli
GuySartorelli approved these changes Jun 16, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit af640bb into silverstripe:4.2 Jun 16, 2024
12 checks passed
@GuySartorelli GuySartorelli deleted the pulls/4.2/remove-self branch June 16, 2024 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli