ENH Use class name instead of self

silverstripe · Jun 5, 2024 · 1f1bdad · 1f1bdad
1 parent bad865d
commit 1f1bdad
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/src/Forms/GridField/GridFieldAddByDBField.php b/src/Forms/GridField/GridFieldAddByDBField.php
@@ -234,6 +234,6 @@ public function getHTMLFragments($gridField)
         $forTemplate->Fields->push($textField);
         $forTemplate->Fields->push($addAction);
 
-        return [$this->targetFragment => $forTemplate->renderWith(self::class)];
+        return [$this->targetFragment => $forTemplate->renderWith(GridFieldAddByDBField::class)];
     }
 }
diff --git a/src/Model/Blog.php b/src/Model/Blog.php
@@ -475,7 +475,7 @@ public function canEditEditors($member = null)
             return $extended;
         }
 
-        return Permission::checkMember($member, self::MANAGE_USERS);
+        return Permission::checkMember($member, Blog::MANAGE_USERS);
     }
 
     /**
@@ -499,7 +499,7 @@ public function canEditWriters($member = null)
             return true;
         }
 
-        return Permission::checkMember($member, self::MANAGE_USERS);
+        return Permission::checkMember($member, Blog::MANAGE_USERS);
     }
 
     /**
@@ -523,7 +523,7 @@ public function canEditContributors($member = null)
             return true;
         }
 
-        return Permission::checkMember($member, self::MANAGE_USERS);
+        return Permission::checkMember($member, Blog::MANAGE_USERS);
     }
 
     /**

diff --git a/src/Model/BlogObject.php b/src/Model/BlogObject.php
@@ -69,7 +69,7 @@ public function validate()
         }
 
         if ($this->getDuplicatesByField('Title')->count() > 0) {
-            $validation->addError($this->getDuplicateError(), self::DUPLICATE_EXCEPTION);
+            $validation->addError($this->getDuplicateError(), BlogObject::DUPLICATE_EXCEPTION);
         }
 
         return $validation;
@@ -204,7 +204,7 @@ public function generateURLSegment($increment = 0)
      */
     protected function getDuplicatesByField($field)
     {
-        $duplicates = DataList::create(self::class)
+        $duplicates = DataList::create(BlogObject::class)
             ->filter(
                 [
                     $field   => $this->$field,

diff --git a/tests/php/Widgets/BlogArchiveWidgetTest.php b/tests/php/Widgets/BlogArchiveWidgetTest.php
@@ -18,7 +18,7 @@ class BlogArchiveWidgetTest extends SapphireTest
     protected function setUp(): void
     {
         if (!class_exists(Widget::class)) {
-            self::$fixture_file = null;
+            BlogArchiveWidgetTest::$fixture_file = null;
             parent::setUp();
             $this->markTestSkipped('Test requires silverstripe/widgets to be installed.');
         }