NEW Remove ImageBackendFactory Injector override from ImageThumbnailHelper #905
Conversation
|
@flamerohr You wrote the original |
maxime-rainville
changed the title
maxime-rainville
force-pushed
the
pulls/1/optimise-image-backend-to-reduce-memory-usage
branch
from
4535dbe to
ca5e80b
Compare
maxime-rainville
changed the base branch from
pulls/1/optimise-image-backend-to-reduce-memory-usage
to
1
| /** | ||
| * @var int | ||
| */ | ||
| private $maxImageFileSize; |
There was a problem hiding this comment.
We prefer protected over private
There was a problem hiding this comment.
In the context that there's a proper accessor and mutator, I think it's better to make it private. My view is people should be using those instead of accessing the variable directly.
There was a problem hiding this comment.
We really need to clarify this policy - consistency is the most important thing in my mind, but we've always gone with protected over private until the last couple of months
| private $maxImageFileSize; | ||
|
|
||
| /** | ||
| * @param mixed $maxImageSize Maximum file size for which thumbnails will be generated. Set to `0` to disable the |
There was a problem hiding this comment.
Mixed is not a useful annotation - I think string|int would be better
|
|
||
| /** | ||
| * Set the maximum file size for which thumbnails will be generated. Set to `0` to disable the limit. | ||
| * @param mixed $size |
maxime-rainville
deleted the
pulls/1/optimise-image-backend-to-reduce-memory-usage
branch
|
@robbieaverill I've addressed your feedback in #910 |
…kend-to-reduce-memory-usage MINOR Implement some of the feedback that got missed from #905
ImageThumbnailHelperoverridesImageBackendFactorywithInjectionCreator. This seems to increase the memory usage systematically when resizing big pictures. Not quite sure why, but I think some object hang around whenInjectionCreator.This doesn't actually show when calling
memory_get_peak_usagebecause the memory is actually used by some process outside of PHP that's responsible for resizing the image.Parent issue