Skip to content

Commit

Permalink
MINOR Implement some of the feedback that got missed from silverstrip…
Browse files Browse the repository at this point in the history
  • Loading branch information
Maxime Rainville committed Jan 29, 2019
1 parent f29848b commit ed0e9b4
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions code/Helper/ImageThumbnailHelper.php
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
use SilverStripe\Core\Convert;
use SilverStripe\Core\Injector\Injectable;
use SilverStripe\ORM\DB;
use SilverStripe\ORM\SS_List;

class ImageThumbnailHelper
{
Expand All @@ -17,7 +18,7 @@ class ImageThumbnailHelper
private $maxImageFileSize;

/**
* @param mixed $maxImageSize Maximum file size for which thumbnails will be generated. Set to `0` to disable the
* @param int|string $maxImageSize Maximum file size for which thumbnails will be generated. Set to `0` to disable the
* limit.
*/
public function __construct($maxImageFileSize = '9M')
Expand All @@ -36,7 +37,7 @@ public function getMaxImageFileSize()

/**
* Set the maximum file size for which thumbnails will be generated. Set to `0` to disable the limit.
* @param mixed $size
* @param int|string $size
* @return $this
*/
public function setMaxImageFileSize($size)
Expand All @@ -48,7 +49,7 @@ public function setMaxImageFileSize($size)
public function run()
{
$assetAdmin = AssetAdmin::singleton();
/** @var File[] $files */
/** @var File[]|SS_List $files */
$files = File::get();

set_time_limit(0);
Expand Down

0 comments on commit ed0e9b4

Please sign in to comment.