MINOR Implement some of the feedback that got missed from #905

silverstripe · Jan 29, 2019 · ed0e9b4 · ed0e9b4
1 parent f29848b
commit ed0e9b4
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/code/Helper/ImageThumbnailHelper.php b/code/Helper/ImageThumbnailHelper.php
@@ -6,6 +6,7 @@
 use SilverStripe\Core\Convert;
 use SilverStripe\Core\Injector\Injectable;
 use SilverStripe\ORM\DB;
+use SilverStripe\ORM\SS_List;
 
 class ImageThumbnailHelper
 {
@@ -17,7 +18,7 @@ class ImageThumbnailHelper
     private $maxImageFileSize;
 
     /**
-     * @param mixed $maxImageSize Maximum file size for which thumbnails will be generated. Set to `0` to disable the
+     * @param int|string $maxImageSize Maximum file size for which thumbnails will be generated. Set to `0` to disable the
      * limit.
      */
     public function __construct($maxImageFileSize = '9M')
@@ -36,7 +37,7 @@ public function getMaxImageFileSize()
 
     /**
      * Set the maximum file size for which thumbnails will be generated. Set to `0` to disable the limit.
-     * @param mixed $size
+     * @param int|string $size
      * @return $this
      */
     public function setMaxImageFileSize($size)
@@ -48,7 +49,7 @@ public function setMaxImageFileSize($size)
     public function run()
     {
         $assetAdmin = AssetAdmin::singleton();
-        /** @var File[] $files */
+        /** @var File[]|SS_List $files */
         $files = File::get();
 
         set_time_limit(0);