568 - jQuery Notice boxes not aligned - Preventing access to settings #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caffeineinc
commented
Jul 10, 2018
caffeineinc
commented
- Change alignment back to left, so that divs can be exposed and closed by the user
- see issue ~4 - jQuery Notice boxes not aligned - Preventing access to settings / history #568 ~4 - jQuery Notice boxes not aligned - Preventing access to settings / history #568
maxime-rainville
approved these changes
Jul 13, 2018
|
@lukereative Can you have a quick look? @caffeineinc's CSS change look good, but it may have unattended side-effects that I wouldn't know off the top of my head. FYI I've changed the target for the PR to the 1 branch. |
- Change alignment back to left, so that divs can be exposed and closed by the user - see issue silverstripe#568 silverstripe#568
maxime-rainville
force-pushed
the
bugfix/568-notification-alignment
branch
from
0f98b90 to
ea0997d
Compare
lukereative
approved these changes
Jul 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.