Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

~4 - jQuery Notice boxes not aligned - Preventing access to settings / history #568

Closed
caffeineinc opened this issue Jul 10, 2018 · 0 comments

Comments

@caffeineinc
Copy link

caffeineinc commented Jul 10, 2018

I'm finding the alignment of the jquery box is preventing navigation through to a page history, or settings as the position: fixed element has a high z-index, and covers the navigation elements.

It's populated from the header x-loginattemptnotifications and contains the content: :In the last 18 secs a successful login attempt to your account was registered. The attempt was made from 14.1.35.58.

The actual div is located 300px to the right of the container, which means the container is present, but never showing the actual content. Perhaps the previous version contained an animation to the left too.

Changing the CSS property to be shown (by assigning .notice-item with left:0 resolves the issue as the dialog can then be seen, and closed if persistent.

This can be reproduced by executing the following in the console:

jQuery.noticeAdd({text: "<p>myspecial text</p>", stay: false, type: 'good'});

You'll notice it isn't shown until the property for left is added. (perhaps the animation was changed, without updating the css property?)

vendor/silverstripe/admin/client/src/styles/legacy/_style.scss L:893

affects 1.1

caffeineinc pushed a commit to caffeineinc/silverstripe-admin that referenced this issue Jul 10, 2018
- Change alignment back to left, so that divs can be exposed and closed by the user
- see issue silverstripe#568 silverstripe#568
maxime-rainville pushed a commit to caffeineinc/silverstripe-admin that referenced this issue Jul 13, 2018
- Change alignment back to left, so that divs can be exposed and closed by the user
- see issue silverstripe#568 silverstripe#568
caffeineinc pushed a commit to caffeineinc/silverstripe-admin that referenced this issue Jul 22, 2018
- Change alignment back to left, so that divs can be exposed and closed by the user
- see issue silverstripe#568 silverstripe#568
caffeineinc pushed a commit to caffeineinc/silverstripe-admin that referenced this issue Jul 22, 2018
- Change alignment back to left, so that divs can be exposed and closed by the user
- see issue silverstripe#568 silverstripe#568
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants