Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TreeDropdownField from React to Entwine #214

Merged

Conversation

flamerohr
Copy link
Contributor

Also fixes Page back button being hidden in mobile view

@flamerohr flamerohr force-pushed the pulls/1.0/entwined-in-a-tree-of-mess branch 2 times, most recently from 295d8f4 to 05e1f50 Compare August 31, 2017 01:31
Enhancement Remove legacy TreeDropdownField which was built in entwine
@tractorcow tractorcow force-pushed the pulls/1.0/entwined-in-a-tree-of-mess branch from 05e1f50 to 8f1139b Compare September 1, 2017 04:49
@tractorcow
Copy link
Contributor

I've noticed this weird behaviour:

If I select multiple items, it only saves the first one.

Before saving:

image

After saving:

image

Can you please have a look into this?

Copy link
Contributor

@tractorcow tractorcow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Multi-select bug

@flamerohr
Copy link
Contributor Author

@tractorcow thanks, issue should be fixed now

@chillu
Copy link
Member

chillu commented Sep 3, 2017

image

Hooray!

@tractorcow tractorcow merged commit 3c0193e into silverstripe:1 Sep 4, 2017
@tractorcow tractorcow deleted the pulls/1.0/entwined-in-a-tree-of-mess branch September 4, 2017 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants