Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use React-based TreeDropdownField in non-React sections #142

Closed
3 tasks done
chillu opened this issue Jul 6, 2017 · 4 comments
Closed
3 tasks done

Use React-based TreeDropdownField in non-React sections #142

chillu opened this issue Jul 6, 2017 · 4 comments

Comments

@chillu
Copy link
Member

chillu commented Jul 6, 2017

Acceptance Criteria

  • I can select one or more items from a hierarchical structure in non-React sections of the CMS
  • The field is tested with existing uses: "Groups" in Page Settings, RedirectorPage, VirtualPage
  • The field looks and behaves the same way as in React-based sections (e.g. in "insert link")
  • The old TreeDropdownField is removed from core. There are no remaining cases where devs would need to fall back to it.
  • Any additional upgrade effort for devs is documented
  • A Behat tests exists for at least one feature path involving this field (e.g. setting a "Group" in "Page Settings")

Notes

  • Motivation for this is consistent UX, and removing the maintenance burden of the old formfield (which has some significant complexity to it)
  • This is expected to cause zero or minimal duplication of code (JS and CSS)
  • Blocked by Implement a TreeMultiSelectField (since we want to get rid of the old field)
  • The new field is expected to have feature parity with the old one, otherwise we're breaking APIs. If that's the case, we might need to move the old field into an optional module
  • We've done a similar React/Entwine bridge through UploadFieldEntwine.js already

Pull requests

Related

@chillu
Copy link
Member Author

chillu commented Jul 6, 2017

@flamerohr Did I capture this correctly? Anything missing which would enable us to size this properly next week?

@chillu chillu added this to the Recipe 4.0.0-beta2 milestone Jul 6, 2017
@flamerohr
Copy link
Contributor

Yeah, I think that captures most of it, perhaps add to the Notes that this is also blocked by the Search feature as well?

This could be in our DOD, but because this will carry a similar set of problems as the EntwineUploadField.js, could we add "behat tests to ensure it is functional" to the ACs so we can capture regressions that may occur in future?

@tractorcow
Copy link
Contributor

Feedback left on admin PR #214 for you @flamerohr

@phalkunz phalkunz assigned tractorcow and unassigned flamerohr Sep 3, 2017
@tractorcow
Copy link
Contributor

Merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants