-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use react-select for react-based dropdowns (SingleSelectField and MultiSelectField) #52
Comments
Overview of current state:
Updated 17/08/2017 |
For the moment, this only affects custom dropdowns in the assets and campaigns section, as well as lesser used core dropdowns in the "asset search" advanced form. Those look OK in their default bootstrap styling already. The UX will be slightly different to ChosenJS dropdowns in Entwine UIs (no search abilities in dropdown options), but I doubt many users will notice. Removing from the 4.0 milestone for now. |
Note: We'll need to support tagfield in react. I'd prefer to see something in this story used to support that feature. |
Adding a note to the previous comment that the TagField implementation (not complete yet) uses the same react-select library we'd probably end up using here for multi select fields, and ideally TagField would then be refactored to use the core form field instead of re-implementing the same thing. FWIW the current state of TagField is that the field works in entwine forms but not in React forms (issues: #755 and silverstripe/silverstripe-tagfield#107) |
This is becoming more of problem as we move more forms to |
I think we can probably consider the Listbox problem as a bug. It looks nothing like it's SSViewer counterpart. |
Acceptance Criteria
<TreeDropdownField>
react componentNotes
react-select
for the new react-based TreeDropdownFieldExcluded
Related
The text was updated successfully, but these errors were encountered: