Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiselect field missing dropdown caret and cross icon #86

Open
sachajudd opened this issue Jan 8, 2019 · 2 comments
Open

Multiselect field missing dropdown caret and cross icon #86

sachajudd opened this issue Jan 8, 2019 · 2 comments
Labels
affects/v4 type/bug Something isn't working

Comments

@sachajudd
Copy link
Contributor

sachajudd commented Jan 8, 2019

Just raising my concern about using a mulitselect field that doesn't have a caret (or cross icon) to indicate that it also has a dropdown. @ScopeyNZ explained potentially because this has text auto complete. I also have concerns about the placeholder text "Select Some Options" due to the contrast for accessibility purposes. We discussed that this is a bug in framework and to raise an issue there which I'll add this week.

image

image

Designs for what we envisioned.

In the meantime for CKAN I think it's worth talking about some alternatives we could use such as using something like tagfield which has a dropdown caret and cross icon.

Any thoughts welcome.

All form designs can be found in our Styleguide

@robbieaverill
Copy link
Contributor

robbieaverill commented Jan 8, 2019

We discussed that this is a bug in framework and to raise an issue there which I'll add this week.

Yeah, I think that's where we should change this pattern. At this stage we're using existing form fields from core, I don't think there's a reason to create new ones - we should update the core ones if needed (being mindful that they'd flow on to all places they're used - which is a good thing I guess).

In the meantime for CKAN I think it's worth talking about some alternatives we could use such as using something like tagfield which has a dropdown caret and cross icon.

To be honest, introducing an extra module dependency in order to achieve this seems pretty low value to me. I think we'd be better to change the multi select design in core instead.

FWIW the core form field is ListboxField here, and this isn't a React form field - the issue we'd need to push forward would be silverstripe/silverstripe-admin#52. TagField already uses the same underlying library, so you'd end up with the same result except it would be in core instead.

@sachajudd
Copy link
Contributor Author

Yeah agreed, I'll cc @clarkepaul into this for now to have a look at.

@GuySartorelli GuySartorelli added the type/bug Something isn't working label Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects/v4 type/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants