This repository has been archived by the owner on Dec 10, 2024. It is now read-only.
API Use new serialize API #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
emteknetnz
force-pushed
the
pulls/master/depr
branch
from
a892f9f to
7b5ac5c
Compare
GuySartorelli
approved these changes
Mar 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/.github#11
Tag (don't release) 3.99.99 when merged - this is so that the composer "replace" works with existing installs that use ^3.6
Latest version on https://github.com/opis/closure is 3.6.3
I've used 3.* based on https://stackoverflow.com/a/18905069 - in that answer it says that using wildcard is bad, however in our case it does what we want it to do
If opis/closure 4 is ever released and the new serialize API is used there, then the silverstripe/closure fork should be deleted and silverstripe/doorman should be updated to use opis/closure again