Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Serializable from asyncphp/doorman #11

Closed
8 tasks
emteknetnz opened this issue Mar 6, 2023 · 2 comments
Closed
8 tasks

Remove Serializable from asyncphp/doorman #11

emteknetnz opened this issue Mar 6, 2023 · 2 comments

Comments

@emteknetnz
Copy link
Member

emteknetnz commented Mar 6, 2023

asyncphp/doorman was previously moved to the silverstripe/doorman repo

doorman is used by symbiote/silverstripe-queuedjobs

doorman still uses the Serializable interface which requires the implementation of the deprecated serialize() and unserialize() methods.

For the rest of our code base that interface and those methods have since been removed and replicated with __serialize() and __unserialize() methods.

There is a unreleased 4 branch for doorman for CMS 5.

ACs

  • Remove Serialize() from doorman
  • Implement __serialize() / __unserialize() if required
  • Create a 4.0 branches from 4 post merge
  • Update the CMS 5 version of symbiote/silverstripe-queuejobs to use ^4 of doorman
  • Remove serialize() / unserialize() from queuedjobs
  • Release doorman 4.0.0-beta1
  • Add doorman 4.x-dev/4.0.x-dev to the root of silverstripe/recipe-kitchen sink so that it gets released as part of 5.0
  • Deprecate serialise() / unserialise() in doorman 3

PRs

@maxime-rainville
Copy link
Contributor

I would be keen to better understand why we didn't pick this up when we first tag the CMS 5 Sink and how we found it later on.

@GuySartorelli
Copy link
Member

Assigning back to @emteknetnz for the remaining ACs (tagging, etc)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants