Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove merged-up deprecations from 5.0 #10

Closed
1 task
emteknetnz opened this issue Mar 2, 2023 · 1 comment
Closed
1 task

Remove merged-up deprecations from 5.0 #10

emteknetnz opened this issue Mar 2, 2023 · 1 comment
Assignees
@GuySartorelli
Labels
affects/v5 impact/high type/api-break

Comments

@emteknetnz
Copy link
Member

emteknetnz commented Mar 2, 2023 •
edited by GuySartorelli
Loading

Searching the codebase for @deprecated and Deprecation:: showed multiple results. Likely these slipped in from the recent 4 -> 5.0 merge-ups

ACs

  • All relevant @deprecated and Deprecation:: notices are removed from all the code in sink

New issues created

PRs
@emteknetnz emteknetnz self-assigned this Mar 5, 2023
This was referenced Mar 6, 2023
Merged
Merged
Merged
@emteknetnz emteknetnz removed their assignment Mar 6, 2023
@GuySartorelli GuySartorelli self-assigned this Mar 6, 2023
@GuySartorelli
Copy link
Member

PRs merged, other cards are their own thing. Couldn't find any other references in our code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GuySartorelli GuySartorelli

Labels
affects/v5 impact/high type/api-break
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@emteknetnz @GuySartorelli