Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 2, 2a, 2b verse merging #214

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Fix 2, 2a, 2b verse merging #214

merged 1 commit into from
Jun 26, 2024

Conversation

johnml1135
Copy link
Collaborator

@johnml1135 johnml1135 commented Jun 20, 2024

sillsdev/serval#411


This change is Reviewable

@johnml1135 johnml1135 requested a review from ddaspit June 20, 2024 16:11
Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @johnml1135)


tests/SIL.Machine.Tests/Corpora/UsfmTextUpdaterTests.cs line 193 at r1 (raw file):

    [Test]
    public void GetUsfm_Verse_2_2a_2b()

You should rename this test. Maybe GetUsfm_MergeVerseSegments.

@johnml1135
Copy link
Collaborator Author

tests/SIL.Machine.Tests/Corpora/UsfmTextUpdaterTests.cs line 193 at r1 (raw file):

Previously, ddaspit (Damien Daspit) wrote…

You should rename this test. Maybe GetUsfm_MergeVerseSegments.

done

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.30%. Comparing base (ceb586c) to head (11060c4).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #214      +/-   ##
==========================================
- Coverage   67.30%   67.30%   -0.01%     
==========================================
  Files         447      447              
  Lines       35433    35432       -1     
  Branches     4736     4736              
==========================================
- Hits        23849    23848       -1     
  Misses      10496    10496              
  Partials     1088     1088              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johnml1135)

@johnml1135 johnml1135 merged commit 1011777 into master Jun 26, 2024
4 checks passed
@johnml1135 johnml1135 deleted the 2_2a_2b branch June 26, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants