Fix 2, 2a, 2b verse merging

sillsdev · Jun 26, 2024 · 11060c4 · 11060c4
1 parent ceb586c
commit 11060c4
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/src/SIL.Machine/Corpora/UsfmTextUpdater.cs b/src/SIL.Machine/Corpora/UsfmTextUpdater.cs
@@ -328,9 +328,8 @@ private IReadOnlyList<string> AdvanceRows(IReadOnlyList<ScriptureRef> segScrRefs
                     if (compare == 0)
                     {
                         // source and row match
-                        // grab the text and increment both
+                        // grab the text - both source and row will be incremented in due time...
                         rowTexts.Add(text);
-                        sourceIndex++;
                         break;
                     }
                 }

diff --git a/tests/SIL.Machine.Tests/Corpora/UsfmTextUpdaterTests.cs b/tests/SIL.Machine.Tests/Corpora/UsfmTextUpdaterTests.cs
@@ -189,6 +189,20 @@ public void GetUsfm_Verse_RangeMultipleRowsSingleVerse()
         );
     }
 
+    [Test]
+    public void GetUsfm_MergeVerseSegments()
+    {
+        var rows = new List<(IReadOnlyList<ScriptureRef>, string)>
+        {
+            (ScrRef("MAT 2:2"), "Verse 2."),
+            (ScrRef("MAT 2:2a"), "Verse 2a."),
+            (ScrRef("MAT 2:2b"), "Verse 2b.")
+        };
+
+        string target = UpdateUsfm(rows);
+        Assert.That(target, Contains.Substring("\\v 2-3 Verse 2. Verse 2a. Verse 2b.\r\n"));
+    }
+
     [Test]
     public void GetUsfm_Verse_OptBreak()
     {