Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle creation and consumption specs #67

Merged
merged 2 commits into from
Apr 20, 2023

Conversation

tnytown
Copy link
Collaborator

@tnytown tnytown commented Apr 18, 2023

Specifies bundle creation and consumption standards by:

  • adding sign-bundle and verify-bundle subcommands;
  • adding the --bundle flag that specifies the bundle to output or verify from.

I'm unsure of if we want to have separate sign-bundle and verify-bundle subcommands, as I mentioned in #65 (comment). I can remove these subcommands and make some flags optional if we feel that approach is better.

Resolves #51.

@tnytown tnytown requested a review from tetsuo-cpp April 18, 2023 22:10
@tetsuo-cpp
Copy link
Collaborator

I understand where you're coming from regarding the flags. I guess my only concern is that sigstore-java are using their CLI not just for conformance testing but for some internal CI stuff to sign/verify things (from my memory). So this approach (which I'd say is a bit less ergonomic) will affect them too.

@loosebazooka Would it be ok if we switch the sigstore-java CLI to use sign-bundle and verify-bundle as separate subcommands rather than a --bundle flag? I'm happy to put a PR together, it's more about whether you intend to use the CLI more extensively.

Copy link
Collaborator

@tetsuo-cpp tetsuo-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Provided that the sigstore-java folks are happy with this approach, let's go with this.

@tnytown
Copy link
Collaborator Author

tnytown commented Apr 19, 2023

Also happy to just collapse them into the same subcommand! I took a crack at implementing some basic bundle tests and since sigstore-python doesn't have separate subcommands, implementing this for the shim is just a matter of deleting -bundle.

@loosebazooka
Copy link
Member

loosebazooka commented Apr 19, 2023

@tetsuo whatever you need for conformance works for us. The cli is not a released artifact and will never be. It's purely for conformance and other testing.

The cli framework we're using lets us create required mutually exclusive groups (--bundle OR --cert/--sig), so that's why it's in there like that for now.

@woodruffw woodruffw mentioned this pull request Apr 19, 2023
@tnytown tnytown marked this pull request as ready for review April 19, 2023 20:48
@tnytown tnytown changed the title WIP: Bundle creation and consumption specs Bundle creation and consumption specs Apr 19, 2023
@tetsuo-cpp
Copy link
Collaborator

@loosebazooka Awesome, thanks for explaining.

@tetsuo-cpp tetsuo-cpp merged commit 2c17568 into sigstore:main Apr 20, 2023
@tetsuo-cpp tetsuo-cpp deleted the ap/issue/51 branch April 20, 2023 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI interface: specify bundle creation and consumption
3 participants