Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i2s: Fix 2 issues. #6

Closed
wants to merge 1 commit into from

Conversation

waveletboy
Copy link
Contributor

  1. WS = 0, Left Channel; WS = 1, Right Channel
  2. Data start and end at falling edge of SCK

1. WS = 0, Left Channel; WS = 1, Right Channel
2. Data start and end at falling edge of SCK
@uwehermann
Copy link
Member

Looks good, thanks! Merged in c78c8f6.

@uwehermann uwehermann closed this Nov 25, 2018
@uwehermann
Copy link
Member

Oh, forgot to mention: I've also updated the sigrok-test repo to match the new decoder output.

If you have any additional i2c example files (*.sr) for our sigrok-dumps repo, that would also be great (for greater test-coverage).

@waveletboy
Copy link
Contributor Author

I have a 16bit 48khz I2S sample. Will upload once I have time. The other thing I noticed is that the I2S sample 2ch-16bit-16khz.sr is actually 32bit 8khz.

@uwehermann
Copy link
Member

Hi, did you get a chance to grab another i2s *.sr file for our sigrok-dumps repo btw?

uwehermann added a commit to sigrokproject/sigrok-dumps that referenced this pull request Apr 30, 2019
uwehermann added a commit to sigrokproject/sigrok-test that referenced this pull request Apr 30, 2019
@waveletboy
Copy link
Contributor Author

waveletboy commented Mar 19, 2020 via email

@waveletboy
Copy link
Contributor Author

waveletboy commented Mar 20, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants