Fix for blank line in graffiti file

[shayanb]

Issue Addressed

Which issue # does this PR address?
#5880

Proposed Changes

Please list or describe the changes introduced by this PR.
Skip empty line as described in the issue 5880

Additional Info

Please provide any additional information. For example, future considerations
or information useful for reviewers.

[CLAassistant]

All committers have signed the CLA.

[michaelsproul]

Hi @shayanb, do you think you could try to add a test too? You can extend or copy the existing test in that file

[shayanb]

@michaelsproul here you go, added tests for different new line scenarios. Let me know if anything else is needed here.

[shayanb]

I'd like to add printing the graffiti in the logs for validator initialization, would it fit in this PR or I can create a new PR for that.

Basically this line in validator_client/initialized_validators/src/lib.rs (although not sure how to test it yet):

                                self.validators
                                    .insert(init.voting_public_key().compress(), init);
                                info!(
                                    self.log,
                                    "Enabled validator";
                                    "signing_method" => "local_keystore",
                                    "voting_pubkey" => format!("{:?}", def.voting_public_key),
                                    **"graffiti" => format!("{:?}", def.graffiti)**
                                );

[michaelsproul]

@shayanb Thanks for the test, looks good!

I think we could add the graffiti logging in a separate PR. There's some subtlety there because the graffiti can change at runtime, so whatever we log on startup won't necessarily stay. It could still be nice to log it though

[michaelsproul]

Cargo fmt is failing, but you can fix it with cargo fmt --all (you can probably also configure your editor to run cargo fmt on save).

[shayanb]

@michaelsproul thanks for the tip, pushed the fmt commit.

I'll submit graffiti logging PR soon.

[michaelsproul]

Looks great, thanks

The CI failure is unrelated, will be fixed by:

• Correct flakey CI tests #6646

[michaelsproul]

@mergify queue

[mergify]

queue

🛑 The pull request has been removed from the queue default

The merge conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

[michaelsproul]

@mergify requeue

[mergify]

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

[mergify]

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 943716b