Blank line at the end of graffiti-file causes error

[davidcann]

Description

A blank line at the end of the graffiti-file causes an error and the entire file to be ignored. There is no mention of blank lines being a problem in the documentation here: https://lighthouse-book.sigmaprime.io/graffiti.html

Version

stable (production release)

Present Behaviour

The entire graffiti-file is ignored when there's a blank line at the end of the text file.

error: InvalidLine("Missing delimiter: "), service: block

Expected Behaviour

Blank lines should be ignored. All valid lines should be read.

Steps to resolve

Add a blank line to the end of the file set via --graffiti-file, then wait for a block proposal or restart the validator client.

[davidcann]

To solve this, add this before /validator_client/src/graffiti_file.rs line 68:

if line.trim().is_empty() {
    continue;
}

lighthouse/validator_client/src/graffiti_file.rs

Line 68 in 3058b96

let (pk_opt, graffiti) = read_line(&line)?;

[michaelsproul]

thanks for the bug report

if you'd like to submit a PR with the fix we can merge it!

[shayanb]

@michaelsproul I took the liberty of submitting a PR for this issue :)