Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v5.2.1 (final branch) #5984

Merged
merged 22 commits into from
Jun 28, 2024
Merged

Release v5.2.1 (final branch) #5984

merged 22 commits into from
Jun 28, 2024

Conversation

michaelsproul
Copy link
Member

Proposed Changes

This is a release branch for v5.2.1 that will be merged to stable without going via unstable.

This is a break from our usual release process which always used fast-forward merges from unstable to stable. The advantage is that we can continue developing breaking changes on unstable while waiting for v5.2.1.

How to include a PR

  • Use release-v5.2.1 as the target branch for any pull request targeting v5.2.1.
  • Label it with the v5.2.1 label.
  • Test and review as normal, then squash merge into this PR (you should use Mergify).

I'm also considering making another test-v5.2.1 PR that can contain squashed PRs for testing, prior to their final merge. Lets try to keep the history on this branch clean (no force pushes) so that it can be back-merged to unstable without creating problems.

realbigsean and others added 18 commits June 13, 2024 01:32
* remove or update unused cfg
* Fix skip-ci on `stable`.
* Fix panic in debug build

* make cli-local to update the book
* max_value -> MAX

* remove unnecesary closures

* a couple more max_value -> MAX

* a couple more max_value -> MAX

* Revert "a couple more max_value -> MAX"

This reverts commit 807fe7c.

* unused spec field -> phantom data

* ignore some dead code warnings

* update kurtosis repo location
* Remove some easy Electra TODOs
* Fix port conflicts on CI.
* Add FUNDING.json
* Remove extern crate
* Verify inclusion proof should not be fallible

* Add blob sidecar inclusion test (#33)

* Add blob sidecar inclusion test.

* Fix lint
* Add test for next_peer_request_ready

* Use push_front to requeue
* Update local testnet doc

* Update doc

* Minor revision

* Fix directory path

* Update scripts/local_testnet/README.md

Co-authored-by: Pawan Dhananjay <[email protected]>

* Add kurtosis web

* Add save logs command

* Log of a service

* Update scripts/local_testnet/README.md

Co-authored-by: Jimmy Chen <[email protected]>

* Update scripts/local_testnet/README.md

Co-authored-by: Jimmy Chen <[email protected]>

* Minor revision

* Merge branch 'local-testnet-doc' of https://github.com/chong-he/lighthouse into local-testnet-doc
* Update nethermind and llvm versions.

* Fix nethermind binary path
* chore: Change Into trait impl for KzgProof to From trait impl

* chore: change `impl Into <T> for U` to `impl From<U> for T`

* chore: remove `from-over-into` clippy lint exception
* chore: simplify method to generate a random blob

* chore: remove now unused import
* Lower tolerance of stale blobs on gossip

* Drop to debug
… but not yet sent. (#5942)

* report failed rpc requests from RPC
* Ensure handler events are covered
* Update book

* Fix

* mdlint

* Revise

* Update slasher doc

* Revise max db size

* change blob to file

* Add checkpoint-blobs

* Thanks Jimmy for the command

* Update schema docs
@michaelsproul michaelsproul changed the title Release v5.2.1 Release v5.2.1 (final branch) Jun 25, 2024
pawanjay176 and others added 3 commits June 26, 2024 23:53
* Remove all batches related to a peer on disconnect

* Cleanup map entries after disconnect

* Allow lookups to continue in case of disconnections

* Pretty response types

* fmt

* Fix lints

* Remove lookup if it cannot progress

* Fix tests

* Remove poll_close on rpc behaviour

* Remove redundant test

* Fix issue raised by lion

* Revert pretty response types

* Cleanup

* Fix test

* Merge remote-tracking branch 'origin/release-v5.2.1' into rpc-error-on-disconnect-revert

* Apply suggestions from joao

Co-authored-by: João Oliveira <[email protected]>

* Fix log

* update request status on no peers found

* Do not remove lookup after peer disconnection

* Add comments about expected event api

* Update single_block_lookup.rs

* Update mod.rs

* Merge branch 'rpc-error-on-disconnect-revert' into 5969-review

* Merge pull request #10 from dapplion/5969-review

Add comments about expected event api
* Attempt to continue lookups after adding peers
@michaelsproul michaelsproul merged commit 9e12c21 into stable Jun 28, 2024
16 of 23 checks passed
@michaelsproul michaelsproul deleted the release-v5.2.1 branch June 28, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.