Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement hash types removing dependency on ethereum_types #10

Closed
AgeManning opened this issue Sep 13, 2018 · 3 comments
Closed

Implement hash types removing dependency on ethereum_types #10

AgeManning opened this issue Sep 13, 2018 · 3 comments
Assignees
@AgeManning
Labels
good first issue Good for newcomers task Task to be completed work-started

Comments

@AgeManning
Copy link
Member

Implement our own version of the types that are currently pulled from ethereum_types removing the create as a dependency.
@AgeManning AgeManning added the task Task to be completed label Sep 13, 2018
@AgeManning AgeManning self-assigned this Sep 13, 2018
@paulhauner paulhauner added the good first issue Good for newcomers label Nov 4, 2018
@vlopes11
Copy link
Contributor

vlopes11 commented Jan 4, 2019

Hello, I'll tackle this one.

I'll fork the code "as is", apply our style and remove the unused types (if any). Ok?

This was referenced Jan 5, 2019
Closed
Closed
@paulhauner
Copy link
Member

Hey @AgeManning, I suggest we close this issue for now. Partly because of the points raised in #132 and also because I don't think this is a priority at the moment. Thoughts?

@AgeManning
Copy link
Member Author

Yep agreed. We can circle back when we need to.

mergify bot pushed a commit that referenced this issue Jun 26, 2024
@pawanjay176
Merge pull request #10 from dapplion/5969-review
59468f8 
Add comments about expected event api
mergify bot pushed a commit that referenced this issue Jun 26, 2024
@pawanjay176
Remove all batches related to a peer on disconnect (#5969)
bf4cbd3 
* Remove all batches related to a peer on disconnect

* Cleanup map entries after disconnect

* Allow lookups to continue in case of disconnections

* Pretty response types

* fmt

* Fix lints

* Remove lookup if it cannot progress

* Fix tests

* Remove poll_close on rpc behaviour

* Remove redundant test

* Fix issue raised by lion

* Revert pretty response types

* Cleanup

* Fix test

* Merge remote-tracking branch 'origin/release-v5.2.1' into rpc-error-on-disconnect-revert

* Apply suggestions from joao

Co-authored-by: João Oliveira <[email protected]>

* Fix log

* update request status on no peers found

* Do not remove lookup after peer disconnection

* Add comments about expected event api

* Update single_block_lookup.rs

* Update mod.rs

* Merge branch 'rpc-error-on-disconnect-revert' into 5969-review

* Merge pull request #10 from dapplion/5969-review

Add comments about expected event api
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AgeManning AgeManning

Labels
good first issue Good for newcomers task Task to be completed work-started
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@paulhauner @AgeManning @vlopes11