Swift: Propagate callback errors directly #108
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simplifies SignalProtocolError at the cost of an extra heap allocation for other errors. On its own, that probably isn't worth it, but this lays groundwork for propagating exceptions / errors back up in the native environment.
jrose-signal
force-pushed
the
jrose/swift-propagate-callback-errors
branch
from
23ec26c
to
686f74c
Compare
|
*sigh* This is what I get for trying to decompose a larger change. I'll come back to this later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This turned out to be easier to do in Swift than in Java, since we already have a Swift-side adapter that catches callback-thrown errors. I have the solution for Java too (#5), but that one's a Rust-side change on top of #76, so I'll put it up later.