Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jni: capture the Throwable #5

Closed
jack-signal opened this issue Oct 16, 2020 · 0 comments · Fixed by #114
Closed

jni: capture the Throwable #5

jack-signal opened this issue Oct 16, 2020 · 0 comments · Fixed by #114
Assignees
@jrose-signal

Comments

@jack-signal
Copy link
Contributor

We currently only capture the name and message if a storage callback throws an exception. Instead capture the entire Throwable and provide it as a the cause field on the relevant exception we throw on the other side.
@jack-signal jack-signal mentioned this issue Oct 16, 2020
Merged
jrose-signal added a commit that referenced this issue Oct 16, 2020
@jrose-signal
Merge pull request #5 from signalapp/jrose/avoid-unnecessary-bytearra…
ed5827e 
…y-copies

Avoid unnecessary copies for bytearray outputs
jrose-signal added a commit that referenced this issue Oct 16, 2020
@jrose-signal
Merge pull request #5 from signalapp/jrose/c99-bool
24afb3e 
Update for 'unsigned char' -> 'bool' change in libsignal-ffi
jack-signal added a commit that referenced this issue Oct 19, 2020
@jack-signal
Merge pull request #5 from signalapp/jack/decode-with-offset
a378dca 
Add offset argument for PublicKey deserialization
@jrose-signal jrose-signal self-assigned this Dec 8, 2020
This was referenced Dec 10, 2020
Closed
Merged
@expiringplatform expiringplatform mentioned this issue Feb 23, 2023
Open
johanvos pushed a commit to johanvos/libsignal-client that referenced this issue May 16, 2023
@tiainen
Merge pull request signalapp#5 from tiainen/skip-signing
9a07a20 
Add option to skip signing for maven publishing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrose-signal jrose-signal

Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Propagate callback exceptions/errors when they fail the whole operation signalapp/libsignal
2 participants
@jack-signal @jrose-signal