Generate and submit registrationId, fixes #25 #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we're expecting to get registrationIds from others, it's only fair that we also supply our own.
| @@ -41,6 +41,8 @@ var single_device = false; | |||
| var signaling_key = window.crypto.getRandomBytes(32 + 20); | |||
| var password = btoa(getString(window.crypto.getRandomBytes(16))); | |||
| password = password.substring(0, password.length - 2); | |||
| var registrationId = new Uint16Array(window.crypto.getRandomBytes(2))[0]; | |||
| registrationId = registrationId & 0x3fff; | |||
There was a problem hiding this comment.
Why 0x3fff instead of 7?
There was a problem hiding this comment.
Why 7?? server api docs say it should be a 14 bit number.
There was a problem hiding this comment.
1 task
1 task
ipbc-dev
pushed a commit
to ra-app/desktop
that referenced
this pull request
Oct 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we're expecting to get registrationIds from others, it's only fair
that we also supply our own.