Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash: "net::ERR_NETWORK_IO_SUSPENDED" after Standby #3102

Closed
1 task done
minnmann opened this issue Feb 4, 2019 · 17 comments
Closed
1 task done

Crash: "net::ERR_NETWORK_IO_SUSPENDED" after Standby #3102

minnmann opened this issue Feb 4, 2019 · 17 comments

Comments

@minnmann
Copy link

minnmann commented Feb 4, 2019

  • I have searched open and closed issues for duplicates

Bug Description

Signal crashes, if the device has been in standby mode for a couple of hours.
Maybe related to #3097, but since I got a slightly different error (see below), I opened a new issue.

Steps to Reproduce

  1. Start Signal and leave it open (in tray)
  2. Put device to standby
  3. Reactivate device after a few hours

Actual Result:
Signal crashes with the following message:

Unhandled Promise Rejection
Error: net::ERR_NETWORK_IO_SUSPENDED
    at GenericProvider.getLatestVersion (C:\Users\[REDACTED]\AppData\Local\Programs\signal-desktop-beta\resources\app.asar\node_modules\electron-updater\src\providers\GenericProvider.ts:18:25)
    at C:\Users\[REDACTED]\AppData\Local\Programs\signal-desktop-beta\resources\app.asar\node_modules\electron-updater\src\AppUpdater.ts:347:26
    at Generator.next (<anonymous>)
    at runCallback (timers.js:696:18)
    at tryOnImmediate (timers.js:667:5)
    at processImmediate (timers.js:649:5)
From previous event:
    at NsisUpdater.getUpdateInfoAndProvider (C:\Users\[REDACTED]\AppData\Local\Programs\signal-desktop-beta\resources\app.asar\node_modules\electron-updater\src\AppUpdater.ts:336:43)
    at C:\Users\[REDACTED]\AppData\Local\Programs\signal-desktop-beta\resources\app.asar\node_modules\electron-updater\src\AppUpdater.ts:363:31
    at Generator.next (<anonymous>)
From previous event:
    at NsisUpdater.doCheckForUpdates (C:\Users\[REDACTED]\AppData\Local\Programs\signal-desktop-beta\resources\app.asar\node_modules\electron-updater\src\AppUpdater.ts:360:34)
    at NsisUpdater.checkForUpdates (C:\Users\[REDACTED]\AppData\Local\Programs\signal-desktop-beta\resources\app.asar\node_modules\electron-updater\src\AppUpdater.ts:220:35)
    at Timeout.checkForUpdates [as _onTimeout] (C:\Users\[REDACTED]\AppData\Local\Programs\signal-desktop-beta\resources\app.asar\app\auto_update.js:22:15)
    at ontimeout (timers.js:427:11)
    at tryOnTimeout (timers.js:289:5)
    at listOnTimeout (timers.js:252:5)
    at Timer.processTimers (timers.js:212:10)

This only happens since the recent update to 1.21.0-beta.3.
In older versions, it regularly showed the "No connection. Retrying in 60s" message - probably due to missing network after wakeup.

Expected Result:
Signal should be in normal state. If the network is gone, it should again just show the reconnecting message.

Platform Info

Signal Version: 1.21.0-beta.3
Operating System: Windows 10
Linked Device Version: 4.33.1

Link to Debug Log

https://debuglogs.org/4b0ef0ad9da7cc49dfec609443df9afb804049c06978448b0ff3fac610b49ef9

@0xnor0
Copy link

0xnor0 commented Feb 4, 2019

same behaviour here:
https://debuglogs.org/8376978035d4dee699dde3c6c9c6e1ba21f6af3637af7145e9c36e562a749907

Unhandled Promise Rejection
Error: net::ERR_NETWORK_IO_SUSPENDED
    at GenericProvider.getLatestVersion (C:\Users\--\AppData\Local\Programs\signal-desktop-beta\resources\app.asar\node_modules\electron-updater\src\providers\GenericProvider.ts:18:25)
    at C:\Users\--\AppData\Local\Programs\signal-desktop-beta\resources\app.asar\node_modules\electron-updater\src\AppUpdater.ts:347:26
    at Generator.next (<anonymous>)
    at runCallback (timers.js:696:18)
    at tryOnImmediate (timers.js:667:5)
    at processImmediate (timers.js:649:5)
From previous event:
    at NsisUpdater.getUpdateInfoAndProvider (C:\Users\--\AppData\Local\Programs\signal-desktop-beta\resources\app.asar\node_modules\electron-updater\src\AppUpdater.ts:336:43)
    at C:\Users\--\AppData\Local\Programs\signal-desktop-beta\resources\app.asar\node_modules\electron-updater\src\AppUpdater.ts:363:31
    at Generator.next (<anonymous>)
From previous event:
    at NsisUpdater.doCheckForUpdates (C:\Users\--\AppData\Local\Programs\signal-desktop-beta\resources\app.asar\node_modules\electron-updater\src\AppUpdater.ts:360:34)
    at NsisUpdater.checkForUpdates (C:\Users\--\AppData\Local\Programs\signal-desktop-beta\resources\app.asar\node_modules\electron-updater\src\AppUpdater.ts:220:35)
    at Timeout.checkForUpdates [as _onTimeout] (C:\Users\--\AppData\Local\Programs\signal-desktop-beta\resources\app.asar\app\auto_update.js:22:15)
    at ontimeout (timers.js:427:11)
    at tryOnTimeout (timers.js:289:5)
    at listOnTimeout (timers.js:252:5)
    at Timer.processTimers (timers.js:212:10)

@Steffen-8
Copy link

Can confirm this error. Get an identical one!

@deive
Copy link

deive commented Feb 6, 2019

I have just had an auto update this morning to 1.21.0 (on Windows) and am got the same error after lunch. This error probably should be caught and ignored, rather than just crashing the app.

Unhandled Promise Rejection
Error: net::ERR_NETWORK_IO_SUSPENDED
    at GenericProvider.getLatestVersion (C:\Users\--\AppData\Local\Programs\signal-desktop\resources\app.asar\node_modules\electron-updater\src\providers\GenericProvider.ts:18:25)
    at C:\Users\--\AppData\Local\Programs\signal-desktop\resources\app.asar\node_modules\electron-updater\src\AppUpdater.ts:347:26
    at Generator.next (<anonymous>)
    at runCallback (timers.js:696:18)
    at tryOnImmediate (timers.js:667:5)
    at processImmediate (timers.js:649:5)
From previous event:
    at NsisUpdater.getUpdateInfoAndProvider (C:\Users\--\AppData\Local\Programs\signal-desktop\resources\app.asar\node_modules\electron-updater\src\AppUpdater.ts:336:43)
    at C:\Users\--\AppData\Local\Programs\signal-desktop\resources\app.asar\node_modules\electron-updater\src\AppUpdater.ts:363:31
    at Generator.next (<anonymous>)
From previous event:
    at NsisUpdater.doCheckForUpdates (C:\Users\--\AppData\Local\Programs\signal-desktop\resources\app.asar\node_modules\electron-updater\src\AppUpdater.ts:360:34)
    at NsisUpdater.checkForUpdates (C:\Users\--\AppData\Local\Programs\signal-desktop\resources\app.asar\node_modules\electron-updater\src\AppUpdater.ts:220:35)
    at Timeout.checkForUpdates [as _onTimeout] (C:\Users\--\AppData\Local\Programs\signal-desktop\resources\app.asar\app\auto_update.js:22:15)
    at ontimeout (timers.js:427:11)
    at tryOnTimeout (timers.js:289:5)
    at listOnTimeout (timers.js:252:5)
    at Timer.processTimers (timers.js:212:10)

@kriegtiger
Copy link

Same problem here. First time it's happened so far.

Bug Description

Computer came out of sleep mode and this error was present on the screen.

Steps to Reproduce

  1. step one - put computer to sleep
  2. step two - wake computer up

Actual Result:

Signal crashed with error message.

Expected Result:

Signal resumed operation.

Screenshots

Did not get screenshot - error message attached in txt file.

Platform Info

Signal Version:

Signal Desktop v1.21.0

Operating System:

Windows 10 - latest patches as of 2/6/19

Linked Device Version:

Signal on Android 4.32.8

Link to Debug Log

PC:
https://debuglogs.org/a7fd7d45b001a6a3320333c086647a786655975bced46760da5c04ffc5024ad4

Android:
https://debuglogs.org/cff66229902c450f67a55d507f31f3737c7427471876a525c3c9c349da88e633

signal crash error.txt

@vleonbonnet
Copy link

I am experiencing the same issue. Seems this bug was introduced in the latest version.

Everytime I wake my computer from sleep, I see this crash from Signal.

Unhandled Promise Rejection
Error: net::ERR_NETWORK_IO_SUSPENDED
    at GenericProvider.getLatestVersion (C:\Users\--\AppData\Local\Programs\signal-desktop\resources\app.asar\node_modules\electron-updater\src\providers\GenericProvider.ts:18:25)
    at C:\Users\--\AppData\Local\Programs\signal-desktop\resources\app.asar\node_modules\electron-updater\src\AppUpdater.ts:347:26
    at Generator.next (<anonymous>)
    at runCallback (timers.js:696:18)
    at tryOnImmediate (timers.js:667:5)
    at processImmediate (timers.js:649:5)
From previous event:
    at NsisUpdater.getUpdateInfoAndProvider (C:\Users\--\AppData\Local\Programs\signal-desktop\resources\app.asar\node_modules\electron-updater\src\AppUpdater.ts:336:43)
    at C:\Users\--\AppData\Local\Programs\signal-desktop\resources\app.asar\node_modules\electron-updater\src\AppUpdater.ts:363:31
    at Generator.next (<anonymous>)
From previous event:
    at NsisUpdater.doCheckForUpdates (C:\Users\--\AppData\Local\Programs\signal-desktop\resources\app.asar\node_modules\electron-updater\src\AppUpdater.ts:360:34)
    at NsisUpdater.checkForUpdates (C:\Users\--\AppData\Local\Programs\signal-desktop\resources\app.asar\node_modules\electron-updater\src\AppUpdater.ts:220:35)
    at Timeout.checkForUpdates [as _onTimeout] (C:\Users\--\AppData\Local\Programs\signal-desktop\resources\app.asar\app\auto_update.js:22:15)
    at ontimeout (timers.js:427:11)
    at tryOnTimeout (timers.js:289:5)
    at listOnTimeout (timers.js:252:5)
    at Timer.processTimers (timers.js:212:10)

@liayn
Copy link

liayn commented Feb 6, 2019

Confirmed.
v1.21.0
win10 64bit

@scottnonnenberg-signal scottnonnenberg-signal changed the title Unhandled Promise Rejection (net::ERR_NETWORK_IO_SUSPENDED) after Standby Crash: "net::ERR_NETWORK_IO_SUSPENDED" after Standby Feb 6, 2019
@daz10000
Copy link

daz10000 commented Feb 7, 2019

I've had this both on wake-up and while I was having intermittent network connection issues, so it's just fragile with respect to network unavailability.

@cheecheeo
Copy link

Also experiencing this.

Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) SignalBeta/1.21.0-beta.4 Chrome/66.0.3359.181 Electron/3.0.14 Safari/537.36 node/10.2.0 env/production
Unhandled Promise Rejection
Error: net::ERR_NETWORK_IO_SUSPENDED
    at GenericProvider.getLatestVersion (C:\Users\John Chee\AppData\Local\Programs\signal-desktop-beta\resources\app.asar\node_modules\electron-updater\src\providers\GenericProvider.ts:18:25)
    at C:\Users\John Chee\AppData\Local\Programs\signal-desktop-beta\resources\app.asar\node_modules\electron-updater\src\AppUpdater.ts:347:26
    at Generator.next (<anonymous>)
    at runCallback (timers.js:696:18)
    at tryOnImmediate (timers.js:667:5)
    at processImmediate (timers.js:649:5)
From previous event:
    at NsisUpdater.getUpdateInfoAndProvider (C:\Users\John Chee\AppData\Local\Programs\signal-desktop-beta\resources\app.asar\node_modules\electron-updater\src\AppUpdater.ts:336:43)
    at C:\Users\John Chee\AppData\Local\Programs\signal-desktop-beta\resources\app.asar\node_modules\electron-updater\src\AppUpdater.ts:363:31
    at Generator.next (<anonymous>)
From previous event:
    at NsisUpdater.doCheckForUpdates (C:\Users\John Chee\AppData\Local\Programs\signal-desktop-beta\resources\app.asar\node_modules\electron-updater\src\AppUpdater.ts:360:34)
    at NsisUpdater.checkForUpdates (C:\Users\John Chee\AppData\Local\Programs\signal-desktop-beta\resources\app.asar\node_modules\electron-updater\src\AppUpdater.ts:220:35)
    at Timeout.checkForUpdates [as _onTimeout] (C:\Users\John Chee\AppData\Local\Programs\signal-desktop-beta\resources\app.asar\app\auto_update.js:22:15)
    at ontimeout (timers.js:427:11)
    at tryOnTimeout (timers.js:289:5)
    at listOnTimeout (timers.js:252:5)
    at Timer.processTimers (timers.js:212:10)

@Nightfirecat
Copy link

I've also run into this error.

Error message
Unhandled Promise Rejection
Error: net::ERR_NETWORK_IO_SUSPENDED
    at GenericProvider.getLatestVersion (C:\Users\Nightfirecat\AppData\Local\Programs\signal-desktop\resources\app.asar\node_modules\electron-updater\src\providers\GenericProvider.ts:18:25)
    at C:\Users\Nightfirecat\AppData\Local\Programs\signal-desktop\resources\app.asar\node_modules\electron-updater\src\AppUpdater.ts:347:26
    at Generator.next ()
    at runCallback (timers.js:696:18)
    at tryOnImmediate (timers.js:667:5)
    at processImmediate (timers.js:649:5)
From previous event:
    at NsisUpdater.getUpdateInfoAndProvider (C:\Users\Nightfirecat\AppData\Local\Programs\signal-desktop\resources\app.asar\node_modules\electron-updater\src\AppUpdater.ts:336:43)
    at C:\Users\Nightfirecat\AppData\Local\Programs\signal-desktop\resources\app.asar\node_modules\electron-updater\src\AppUpdater.ts:363:31
    at Generator.next ()
From previous event:
    at NsisUpdater.doCheckForUpdates (C:\Users\Nightfirecat\AppData\Local\Programs\signal-desktop\resources\app.asar\node_modules\electron-updater\src\AppUpdater.ts:360:34)
    at NsisUpdater.checkForUpdates (C:\Users\Nightfirecat\AppData\Local\Programs\signal-desktop\resources\app.asar\node_modules\electron-updater\src\AppUpdater.ts:220:35)
    at Timeout.checkForUpdates [as _onTimeout] (C:\Users\Nightfirecat\AppData\Local\Programs\signal-desktop\resources\app.asar\app\auto_update.js:22:15)
    at ontimeout (timers.js:427:11)
    at tryOnTimeout (timers.js:289:5)
    at listOnTimeout (timers.js:252:5)
    at Timer.processTimers (timers.js:212:10)

@wumpus42
Copy link

wumpus42 commented Feb 7, 2019

Got the same exception message (twice) this morning when waking up my PC: Windows 10 64bit, Signal 1.21.0. I'm pretty sure I was updated to 1.21.0 yesterday.

@barelyadev
Copy link

barelyadev commented Feb 8, 2019

Can confirm.

Unhandled Promise Rejection
Error: net::ERR_NETWORK_IO_SUSPENDED
    at GenericProvider.getLatestVersion (C:\Users\user\AppData\Local\Programs\signal-desktop\resources\app.asar\node_modules\electron-updater\src\providers\GenericProvider.ts:18:25)
    at C:\Users\user\AppData\Local\Programs\signal-desktop\resources\app.asar\node_modules\electron-updater\src\AppUpdater.ts:347:26
    at Generator.next (<anonymous>)
    at runCallback (timers.js:696:18)
    at tryOnImmediate (timers.js:667:5)
    at processImmediate (timers.js:649:5)
From previous event:
    at NsisUpdater.getUpdateInfoAndProvider (C:\Users\user\AppData\Local\Programs\signal-desktop\resources\app.asar\node_modules\electron-updater\src\AppUpdater.ts:336:43)
    at C:\Users\user\AppData\Local\Programs\signal-desktop\resources\app.asar\node_modules\electron-updater\src\AppUpdater.ts:363:31
    at Generator.next (<anonymous>)
From previous event:
    at NsisUpdater.doCheckForUpdates (C:\Users\user\AppData\Local\Programs\signal-desktop\resources\app.asar\node_modules\electron-updater\src\AppUpdater.ts:360:34)
    at NsisUpdater.checkForUpdates (C:\Users\user\AppData\Local\Programs\signal-desktop\resources\app.asar\node_modules\electron-updater\src\AppUpdater.ts:220:35)
    at Timeout.checkForUpdates [as _onTimeout] (C:\Users\user\AppData\Local\Programs\signal-desktop\resources\app.asar\app\auto_update.js:22:15)
    at ontimeout (timers.js:427:11)
    at tryOnTimeout (timers.js:289:5)
    at listOnTimeout (timers.js:252:5)
    at Timer.processTimers (timers.js:212:10)

@silent5am
Copy link

silent5am commented Feb 8, 2019

Same error also.

Unhandled Promise Rejection
Error: net::ERR_NETWORK_IO_SUSPENDED
    at GenericProvider.getLatestVersion (C:\Users\XXX\AppData\Local\Programs\signal-desktop\resources\app.asar\node_modules\electron-updater\src\providers\GenericProvider.ts:18:25)
    at C:\Users\XXX\AppData\Local\Programs\signal-desktop\resources\app.asar\node_modules\electron-updater\src\AppUpdater.ts:347:26
    at Generator.next (<anonymous>)
    at runCallback (timers.js:696:18)
    at tryOnImmediate (timers.js:667:5)
    at processImmediate (timers.js:649:5)
From previous event:
    at NsisUpdater.getUpdateInfoAndProvider (C:\Users\XXX\AppData\Local\Programs\signal-desktop\resources\app.asar\node_modules\electron-updater\src\AppUpdater.ts:336:43)
    at C:\Users\XXX\AppData\Local\Programs\signal-desktop\resources\app.asar\node_modules\electron-updater\src\AppUpdater.ts:363:31
    at Generator.next (<anonymous>)
From previous event:
    at NsisUpdater.doCheckForUpdates (C:\Users\XXX\AppData\Local\Programs\signal-desktop\resources\app.asar\node_modules\electron-updater\src\AppUpdater.ts:360:34)
    at NsisUpdater.checkForUpdates (C:\Users\XXX\AppData\Local\Programs\signal-desktop\resources\app.asar\node_modules\electron-updater\src\AppUpdater.ts:220:35)
    at Timeout.checkForUpdates [as _onTimeout] (C:\Users\XXX\AppData\Local\Programs\signal-desktop\resources\app.asar\app\auto_update.js:22:15)
    at ontimeout (timers.js:427:11)
    at tryOnTimeout (timers.js:289:5)
    at listOnTimeout (timers.js:252:5)
    at Timer.processTimers (timers.js:212:10)

@gsatliawol
Copy link

Ditto. Seems to be pretty consistent. Win7, latest version.

The bug was introduced in the latest update; it hadn't done it before I updated, so that narrows the attack surface for bug hunters...

@scottnonnenberg-signal
Copy link
Contributor

We expect this to be fixed by v1.21.1. Please let us know!

@minnmann
Copy link
Author

minnmann commented Feb 9, 2019

Seems to be fixed for me - no issues so far. Thanks for working on that!
Didn't want to close the issue just yet as it seems to have affected quite a lot people.

@Nightfirecat
Copy link

I agree, I've not seen this again since updating to 1.21.1, where I encountered the bug often before that update. 👍

@gsatliawol
Copy link

I've only done it once since the fix, but since it was pretty consistent in previous version, if others are seeing it fixed, I'm willing to call it closeable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests