-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error Handling Incoming Message - Bad MAC #2912
Comments
Messages are sent between your devices to share information like 'was this message read?' In this case, it looks like those sync messages from your phone to your desktop instance had some sort of problem. Were sync messages happening successfully before that? Were messages showing up as read on your desktop if you had already read them on your phone? |
I've been having the same issue recently. I reset the session, then messages I sent from my phone began showing up properly on the desktop client, but messages received still showed up with the "Bad MAC" error. I use multiple computers with the desktop client, and they all exhibit the same behavior. The mobile client appears to work fine, and at least before I reset the session I had to use the mobile client to send messages otherwise I would get an error when attempting to send. |
Yes, sync messages were happening just fine before that. I even disconnected and reconnected my desktop app to see if that would fix the issues, but it doesn't appear to. I recently was told that several people aren't receiving my messages sent from my desktop app, even after resetting the session. My phone also isn't showing some of the messages I have sent using my desktop app on one of my computers. I use the signal desktop app on multiple computers, so I am not sure if that causes issues or not, but I assume it shouldn't. I also ran into the same issue AlecRosenbaum listed, where I had to send messages using the mobile client, because I would get an error when attempting to send from my desktop app. |
i experienced this today and only on my mac desktop client. my ios client didnt display the errors. here are the debug logs (thx scott): https://debuglogs.org/532fc1e430c2605df28ef2181bf36706a7e84ca13d75e5a05575259b6080bb7d Also some info about one of the three errors I received.
|
@yshuman1 Please, when you report issues, include the debug log ( |
sorry about that @scottnonnenberg-signal, thanks for the reminder. I've updated the prior comment with a link to the logs. |
@yshuman1 Another key bit of data would be some information about which conversations have these errors. Do you message with these people often? When was the last successful message from that person? Did they happen to have switched devices (moving from mobile to desktop?). It would really help to get a log from the device(s) that produced these Bad Mac errors. |
I am having the same issue. here are my logs: |
Also experiencing this. Only bit of useful information to share is that it happened the day after I sent messages to myself. Yes, I do that. Desktop > Mobile sharing. Signal Desktop: v1.19.0 |
@AdrGeorgescu @AMHUSTLE Which of your contacts are generating these errors to you? Do they message you often? What change has happened on their or your side recently? |
This error showed in a message to ME, from ME today. Desktop Signal to Mobile Signal. The odd thing is that the errors show a timestamp of last Saturday/Friday and there are roughly 20 notifications that show the same "Error handling incoming message" with the Friday/Saturday timestamp. I just got what seems like a random purge of error messages today. There isn't a 1:1 relationship between messages I sent to myself and error notifications either. I sent myself 3 messages, and got at least 20 of these error messages. Worth noting: I only see the "Error handling incoming message" error messages on my Desktop Signal app. Mobile shows the conversation with myself as it should, error-free. This same thing happened in one other thread between a friend and I. I confirmed with him that he didn't see any errors on his side. To answer your question, yes, I message this contact on a daily basis, 100+ times a day. There was no 1:1 relationship between messages and error messages in this thread either. My only theory is a version mismatch between my desktop Signal and Mobile signal. Maybe my mobile version was running a newer version than desktop or something, but I'm obsessive about updates, so I'd be surprised if I wasn't running the latest version on both mobile & desktop. Can't confirm though. |
Having the issue again now. Here is a link to the debug logs for Signal Desktop: Here is a link to the debug logs for Signal Android: Has there been any progress made on this? |
@scottnonnenberg-signal hey sorry for the delayed response. the thread updates were in the wrong email folder...fixed now It's happening again and I can answer those questions as well as provide new logs. it's primarily with one other signal user. It's happened a few times since my initial post but todays errors have been the most in occurrence. The errors appear to be dated tuesday the 15th (that is the correct date). and i have successfully been communicating with that person throughout the week. I'm not sure about the other person but i do switch between desktop and mobile often. here are the logs: mobile: https://debuglogs.org/5806191fe076b1eea77456f9455a7b89b96606ac3330dbfc0f985756401261b3.zip I dont know if it helps but i have the delete timer set to 12hrs and i know on the tuesday, we sent several pics to each other as well as text that all went through okay. its only now that i log into desktop that i see the errors. they do not appear on my mobile.
|
MacOS X 10.13.6 Just completed a restore from Time Machine. When I launch Signal, I get many error messages from many other discussions "Error Handling Incoming Message - Bad MAC". Most of these messages are ones that were sent while the desktop machine was down and restoring (took over a day to complete the restore). I've attached a copy of the debug log. The messages appear correctly on my iPhone. Thanks. -- Mark |
First, the workaround is to use 'Reset Secure Session' in the conversations with errors. Second, given your scenario, restoring an old snapshot of SIgnal data, Bad MAC errors are expected. When you exchange messages with a contact on SIgnal, information is updated on both sides, and subsequent messages are encrypted with that information. In those conversations with errors, you vert likely sent a message from the Signal Desktop you erased and replaced with the backup-sourced older data. So data necessary for encryption and decryption was lost in that case. The good news: You didn't end up with a corrupted database, which can happen sometimes if the database backup happens at the wrong time! |
I chose "Reset Session" ... but, nothing changed.
The backup was a snapshot from a day ago -- not really an "old" snapshot. :-)
Yeah. Thanks for the quick response. Also, I'm noticing that my desktop app and iPhone are no longer "synced". -- Mark |
@marquedej Old is subjective. It can be weeks or just a day - it's about the amount of lost data, really the number of people you sent to. Reset session won't fix the old messages - it will allow future messages to go through successfully. Are you saying that messages are still failing? |
@scottnonnenberg Heh. True! Yes, receiving messages are still failing. [UPDATE] |
I kept receiving bad mac errors after choosing reset secure session as well.
Jared Burr
[email protected]
801.472.9538
…On Thu, Jan 31, 2019 at 10:48 AM marquedej ***@***.***> wrote:
@scottnonnenberg <https://github.com/scottnonnenberg> Heh. True!
Yes, receiving messages are still failing.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2912 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ANNq0zANjcDh8Yq6YB4IeQ8VYg7FIiAFks5vIyx-gaJpZM4YnOjM>
.
|
@Bit4BitForensics When did that happen? The last three days? If so, please enter a new bug and provide a debug log. Conceptually, you're sending a message to that user and telling their device to reset some cryptography information. Any message they send you before they receive and process that reset session message will continue to show errors. |
I got some of these Bad MAC errors today on a device that is used regularly (almost every day), so to the best of my knowledge, there should not have been any message counter overflow etc. However, I put the device to standby while it has been fetching messages. So maybe could it be related to fixing #3102? Version: 1.21.1-beta.1 One example message ID is 1549632241839. Edit: It happened again, yet again for the same contact. This time I did not interrupt the message fetching process. It just happened right after I woke the device from standby and it fetched all the new messages (only having trouble for this specific contact). |
When starting a Desktop client after being offline for a while, my contacts are flooded with Bad Encrypted messages Android with Bad messages: https://debuglogs.org/5fd52659b974018f936a8f0731795a16ccbf8e0edb704b6e3f0bc12b44f76529 My desktop client on Linux: https://debuglogs.org/15a8259c72b726c5a7ccf18ea3935abf1786c67686da70eccd90879efd479098 This happened using Signal desktop 1.21 on a Linux and Mac with a contact on Android |
@skulumani That's an Android log. Did you mean to upload a desktop log? |
Thanks for the heads up. I've updated the original comment |
@skulumani Oh, it was your contacts that got hit with a lot of errors. I see. What you've described is probably this bug: #2806 Please comment there and give full details about the history of your Desktop instance. We have fixed on reason that behavior can happen, but as you've experienced, there are potentially other avenues to the bug. |
Same problem as chocolatekitkat with the same screen, and also limited to a single contact. I'm running W10 Pro fully updated, Signal desktop V1.26.2, iOS 12.3.1, Signal 2.41.1.2. The problem does not occur when I use the desktop app to send a message to the problem contact. It does occur when I use the iOS app to send messages to that contact. The problem began when I received a series of "Received message was out of sync" messages on Signal iOS in the message stream with the problem contact. Each of these messages offered a Reset Session button. I clicked on one of these buttons, I think the last but I'm not sure. After that, I received an "Error handling incoming message" notification on Signal desktop each time I sent a message to the problem contact using Signal iOS. |
Just after opening Signal today i was getting the Bad Mac error for one contact aswell. It was working fine yesterday and i exchanged plenty of messages. no Crash noted before. Here is the debug log: https://debuglogs.org/20f03627a35d41c509d0d9eb321dfefd88c75746c5496d44d9d1f9f8df939bef |
Computer did. I occasionally get a kernel panic with a problematic app. Signal was open at the time. |
I have the same issue with one of my contacts only in one of my Signal desktop-apps. No problem with the app on my iPhone, no problem with the desktop apps on my Windows-10-machine and on one of my Ubuntu-20.04-machines. Currently I have no access to these machines so I can't verify the isntalled app versions. On a second Ubuntu-machine, running under version 18.04.06 I get the error https://debuglogs.org/4597fdee8bd2eaed0103ec52aaeea4bddcf34e76fedbd2731b2ce05affa6363f |
I'm also getting this error on a bunch of messages I received yesterday. I only just installed and linked the desktop app (Windows 10 64 bit) yesterday, to be able to write with this friend. Older messages don't seem to be loaded, which I think is by design ("For your security, conversation history isn't transferred to new linked devices"). Here are my debug logs: Edit: Messages received after starting the app are fetched/display all right. Edit 2: Now (the day after the above) I opened the desktop app again, and the old broken messages are still broken, but the messages that arrived yesterday are still visible. Not sure if that's just because they're cached... |
The availability of one of several devices which are used by the same Signal user seems to be the source of this problem. The user solution (just worked for me) is to reset the session. The solution in the code may be to send NON-encrypted notification from a device that receives the "Bad MAC" error to the device that sent the message so that the two of them can re-synchronize their handling of encryption keys. If I understand correctly, one device gets the message and shares it with the others, because exactly one of them must update the conversation key. Anyway, here's why I came up with that: Signal on my phone often stalls or crashes (signalapp/Signal-Android#9292). Today I thought I lost my phone so my daughter placed a Signal call to it and it didn't ring (even though it was hiding right next to me). When I finally found it, I noticed new messages from a new contact. On my phone, all those messages were fine, but on my Desktop, they were all "Bad MAC" errors. I concluded that Signal stalled long enough for it to timeout on its attempt to communicate the updated crypto keys to the desktop, and that's why resetting the session fixed the problem (for new messages, not the old ones). If you have questions, please ask. Debug log: https://debuglogs.org/d24338d9e773f18749ab385e09f709143f7ba27efc65b1607051df7e779f24da |
@dscotese Looks like Desktop had some difficulty with that contact - at one point only knowing about the phone number, and then at one point only knowing about that contact's UUID. What is Desktop's history with that contact?
|
Good find. There was no history. The very first message was a "Bad MAC" error. |
Hm... Might have been known to desktop via your contacts? |
I'm seeing the same error, but the circumstances causing it might be different:
History: I initially contacted the recipient using the desktop app for windows, then later messaged the recipient using my phone. Both of these initial attempts worked fine. When I logged back into the desktop app, all of the messages I had received during the prior day's phone app conversation were missing, and only the messages I had sent appeared on desktop. The missing messages were each replaced with two bad MAC errors. It looks like messages I had sent generated a single BAD MAC error, while messages I should have received generated two BAD MAC errors. All the messages I sent on mobile, which were sent, received, and read, only indicate that they were sent on desktop, not that they were received and read (which they were). I'm not seeing any errors on the phone app. Now, to test I just sent a message from the desktop app. No BAD MAC error was generated on desktop or android app, but both apps only indicate that the message was sent but not received. No messages sent from the desktop app indicate received or read status. |
@dostillevi Thanks for providing your log. We have a theory as to what happened to you, and a fix to go along with that. Please tell us if you still see periodic Bad MACs on our next build, when that comes out. |
Thanks, I haven't seen the issue since. Glad you were able to identify the cause! |
I just got this same error on Signal for Mac (macOS Big Sur). I use Signal on my Mac, Android and iOS Device but I see the Bad MAC error messages only on the Mac app in my "Personal notes" chat (the conversation with myself) even if I don't use it. |
@MEPoss Your debug log would be really useful; it would allow us to investigate your situation further. Please always include it when reporting problems. |
I reset my Mac Signal app disconnecting It from my phone and reconnecting It again, I don't know if the log can still be useful or not.
Il 5 gen 2021, 18:59 +0100, Scott Nonnenberg <[email protected]>, ha scritto:
… @MEPoss Your debug log would be really useful; it would allow us to investigate your situation further. Please always include it when reporting problems.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Just installed Signal yesterday and I already have 16 message exactly like the one from @apoorvkhurasia in the message above. |
@skerkewitz: please attach debug log, otherwise developers can not find the root cause of the issue. |
Since few days I have a lot of "bad mac" error only in the "message to me" feed. The only thing I can see is that the received/read flags of past messages (no the latest send for test) in my "message to me" feed are not synchronized : all flags are ok on my android device but not on my macOS Signal Desktop. Signal 1.39.4 I've send the same message by the "send debug log" function available into the app. |
I'm not sure why this message does not show up here, but I've got this email notification from GitHub a couple of days ago:
I tried it and indeed it fixed the problem for me! |
I've run into the same issue immediately after installing Signal on iOS and Ubuntu. "Reset Session" (on the only conversation I had) makes no difference. What worked for me is: |
@offero @skerkewitz @schauerte v1.39.6, release last week, should have resolved this issue. I'm going to close this; please open a new bug if you're still encountering this. Thanks! |
Hi There, |
Same error with the desktop client (v1.40.0) on Ubuntu 20.04. No problems on Android. |
Same error with desktop client (v1.40.1) on Fedora 32. No problems on Android. Same experience as above, |
Iam using Signal on multiple Clients, Android and Windows. I got these "Bad MAC" Problems too on Windows. Android is fine. Windows Version 1.40.1. |
Same messages on Arch Linux with 1.40.1 |
Bug description
I get this message coming from my own phone number when I turn on my Signal app after a day or so of not using it.
Steps to reproduce
Actual result:
I receive many bad MAC messages from my own phone number for some reason.
Expected result:
I shouldn't receive bad MAC messages from my own phone number.
Screenshots
Platform info
Signal version:
v1.18.0
Operating System:
Win 10 Pro
Linked device version:
Android - Signal 4.29.7
Link to debug log
https://debuglogs.org/41dd3284e4fb475b51df336ff525c5fe46627940baa0d40a8ad5f5e45c964f22
The text was updated successfully, but these errors were encountered: