Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Modulation Extension Namespace (Take2) #140

Merged
merged 8 commits into from
Jul 28, 2021

Conversation

jacobagilbert
Copy link
Member

@jacobagilbert jacobagilbert commented Jul 1, 2021

#120 needs some attention in order to get merged into this release, so this is a modification of that PR with the following changes:

  • Removed boilerplate that already exists in the core spec (this is a canonical extension and it is redundant, and having it is inconsistent w/ other in-tree extensions)
  • Implemented simplified structure (flattened by one level)
  • Taking note of geolocation: update to use GeoJSON #135 this uses consistent (GeoJSON) notation for position
  • Taking note of add short form field to annotation #136 this does not re-implement the label key
  • Removes the explicit overqualified (analog) / (digital) fields where not necessary
  • Uses NTIA style section numbering (good idea @Teque5)
  • Examples updated per the above
  • Adds power values to the emitter object
  • Fixed a few table headings
  • Some spelling fixes

@bhilburn Two items here rely on still-open PRs but both are essentially 'done' AFAIK, once those are merged this is 'atomic'.

Closes #120

Thanks to @Atheatos for all the work to get this to where you did!

bhilburn and others added 8 commits July 20, 2018 15:54
This redesign migrates the extension from a single-string ABNF format to
a JSON object structure.
Overview:
 - rename `modulation` to `signal`
 - add free-form `label` field to label the signal
 - move signal attribute fields to nested `detail` object
 - add nested `emitter` object to describe the communication system
   driver
 - update examples

Changes to `detail` fields:
 - add `channel` field
 - rename `system` to `standard`
 - add `class_variant` field to support modulation variants such as
   pi/4-DPSK and GMSK
Signed-off-by: Jacob Gilbert <[email protected]>
@jacobagilbert jacobagilbert requested a review from bhilburn July 1, 2021 16:17
@jacobagilbert jacobagilbert changed the title Modulation ext take2 Refactor Modulation Extension Namespace (Take2) Jul 1, 2021
@jacobagilbert jacobagilbert added this to the Release v1.0.0 milestone Jul 1, 2021
@jacobagilbert
Copy link
Member Author

@bhilburn Side note: I don't understand why this is showing Commits from you on Jul 20, 2018 and the original does not... I created a new branch from Atheatos's PR. Let me know if this is an issue and how it should be resolved.

@bhilburn
Copy link
Contributor

I don't have requested changes, here! Thanks so much for your great work on this, @Atheatos and @jacobagilbert 🙌

@bhilburn bhilburn merged commit 88faccb into sigmf:master Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants