Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add short form field to annotation #136

Merged
merged 1 commit into from
Jul 28, 2021

Conversation

jacobagilbert
Copy link
Member

Per discussion in #120 and elsewhere, there is no short-form machine readable core field, and many situations where this is valuable.

closes #131

@Teque5
Copy link
Collaborator

Teque5 commented Jun 19, 2021

Any changes to the spec should also update the schema.

@jacobagilbert jacobagilbert force-pushed the add_short_form_to_anno branch from 359fa69 to 60e4997 Compare June 25, 2021 18:51
@jacobagilbert
Copy link
Member Author

@Teque5 I updated the spec and changed the field name to label instead of description since I agree with your other comment. I put may/should language describing the 20 character recommended limit; i don't think it makes sense to force this but I agree it is a good idea to provide some guidance for 'best' compatibility.

sigmf-spec.md Outdated Show resolved Hide resolved
@jacobagilbert jacobagilbert force-pushed the add_short_form_to_anno branch from 60e4997 to eabbd26 Compare June 26, 2021 01:44
Copy link
Contributor

@bhilburn bhilburn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a question re: removal of whitespace semanticism, requested change on label spec text.

Thanks for filing this, @jacobagilbert!

sigmf-spec.md Outdated Show resolved Hide resolved
sigmf-spec.md Outdated Show resolved Hide resolved
@jacobagilbert jacobagilbert force-pushed the add_short_form_to_anno branch from eabbd26 to 2592062 Compare July 1, 2021 02:18
@bhilburn bhilburn merged commit 9c13d43 into sigmf:master Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add short-form human or machine readable field to annotations
3 participants