feat: allow using dateStrings with specific types
#1200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This aligns the `dateStrings` with mysqljs, allowing to set `dateStrings: ['DATE']` to return the DATE type as string, but keeping other datetime types processed to Date. Related: sidorares#99
|
Thanks @B4nan ! |
|
Do you have a rough ETA for a release? I am making some performance optimisations in MikroORM that required this change, and would rather not ship changes that depend on unreleased version :] |
|
@B4nan your change is published now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aligns the
dateStringsoption with mysqljs, allowing to setdateStrings: ['DATE']to returnthe DATE type as string, but keeping other datetime types processed to Date.
Related: #99