dateStrings not implemented.

[JemiloII]

mysql.createConnection({
    host        : 'localhost',
    user        : 'root',
    password    : 'pass',
    database    : 'dbname',
    dateStrings : 'DATE' //this does nothing
});

I tried the other dateStrings commands and they didn't work. So I just installed the original and the dateStrings method works just fine.

[sidorares]

Yes, it's currently ignored. I'll add support for this option in next release

[JemiloII]

thanks!!

[sidorares]

published as v0.12.1

Note that it's a boolean option ( though if you set it to 'DATE' string it's still treated as truthy )

[JemiloII]

Your the bomb! I'll keep on mind that it's a boolean and just set it to true :)

Andrey Sidorov [email protected] wrote:

published as v0.12.1

Note that it's a boolean option ( though if you set it to 'DATE' string it's still treated as truthy )

—
Reply to this email directly or view it on GitHub.

[kbsanders]

I really only want DATE fields to be treated as strings but not DATETIME fields. I see that mysqljs/mysql now supports an array of types for dateStrings in addition to a boolean value. Will we see the same option added to mysql2?

In their Connection Options:

dateStrings: Force date types (TIMESTAMP, DATETIME, DATE) to be returned as strings rather than inflated into JavaScript Date objects. Can be true/false or an array of type names to keep as strings. (Default: false)

[sidorares]

wow, I missed that this was added to mysqljs/mysql

it's relatively simple change - would you like to try adding it @kbsanders ? Let me know if you need any help navigating the code

[kbsanders]

@sidorares Thanks for the quick reply. If I find time in the next few days I will submit a PR.

In the meantime, I'm using this workaround of providing a typeCast in the options:

// NOTE: only works for .query() calls and not .execute() calls.
typeCast: function ( field, next ) {

    if ( field.type === "DATE" ) {
        return field.string();
    }
    
    return next();
}

Along the way I discovered that typeCast was only being called for .query() and not .execute() so I had to refactor my code to use .query(). I don't know if this is a limitation of the way prepared statements work or not, but I guess that is a topic for a new issue.

[sidorares]

I don't know if this is a limitation of the way prepared statements work or not, but I guess that is a topic for a new issue.

see discussion in #649 and #717