Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed support for kovan #463

Merged
merged 6 commits into from
Sep 13, 2022
Merged

Removed support for kovan #463

merged 6 commits into from
Sep 13, 2022

Conversation

zoey-kaiser
Copy link
Contributor

Closes #462

Screenshot 2022-09-12 at 12 22 33

RIP Kovan 😢

Checklist:

  • issue number linked above after pound (#)
    • replace "Closes " with "Contributes to" or other if this PR does not close the issue
  • issue checkboxes are all addressed
  • manually checked my feature / not applicable
  • wrote tests / not applicable
  • attached screenshots / not applicable

@valiafetisov

This comment was marked as resolved.

@zoey-kaiser
Copy link
Contributor Author

including notification-service

In order to remove it properly there I had to remove one of the subscriptions. This was due to it only working on kovan and it was our test subscription until now.

Copy link
Contributor

@valiafetisov valiafetisov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Can you please also check localhost, staging and production secrets (that are used in drone config) to not point to kovan? If you do, please provide the secret commands here to double check

notification-service/src/constants/SUBSCRIPTIONS.ts Outdated Show resolved Hide resolved
notification-service/README.md Outdated Show resolved Hide resolved
@zoey-kaiser
Copy link
Contributor Author

zoey-kaiser commented Sep 12, 2022

Checked secrets:

  • localhost/notification-service
  • localhost/frontend
  • localhost/bot
  • staging/notification-service
  • staging/frontend
  • staging/bot
  • production/notification-service
  • production/frontend
  • production/bot

I only have access to the localhost secrets. Therefore it would be awesome if you could check them (even tho I do not think any other environments other then localhost would use a test network)

secret export auction-ui/production.auction-ui.k8s.sidestream.tech/frontend
secret export auction-ui/production.auction-ui.k8s.sidestream.tech/notification-service
secret export auction-ui/production.auction-ui.k8s.sidestream.tech/bot
secret export auction-ui/main.auction-ui.k8s.sidestream.tech/frontend
secret export auction-ui/main.auction-ui.k8s.sidestream.tech/notification-service
secret export auction-ui/main.auction-ui.k8s.sidestream.tech/bot

@valiafetisov
Copy link
Contributor

Thanks for the commands! Both auction-ui/main.auction-ui.k8s.sidestream.tech/bot and auction-ui/main.auction-ui.k8s.sidestream.tech/notification-service had ETHEREUM_NETWORK set to kovan (although for the bot this variable is no longer used). Fixed both nevertheless

@zoey-kaiser
Copy link
Contributor Author

Thanks for the commands! Both auction-ui/main.auction-ui.k8s.sidestream.tech/bot and auction-ui/main.auction-ui.k8s.sidestream.tech/notification-service had ETHEREUM_NETWORK set to kovan (although for the bot this variable is no longer used). Fixed both nevertheless

TYSM! Are we ready for merge then?

@valiafetisov valiafetisov merged commit b398c5b into main Sep 13, 2022
@valiafetisov valiafetisov deleted the remove-kovan-network branch September 13, 2022 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Kovan network support
2 participants