Skip to content

Commit

Permalink
feat: Removed support for kovan network (#463)
Browse files Browse the repository at this point in the history
  • Loading branch information
zoey-kaiser authored Sep 13, 2022
1 parent 4ede1ec commit b398c5b
Show file tree
Hide file tree
Showing 9 changed files with 16 additions and 32 deletions.
2 changes: 1 addition & 1 deletion bot/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ Testing scenario:

1. Create `./bot/.env` file all variables from `auction-ui/bot/staging` or `auction-ui/bot/production`
2. Start the project in production mode, i.e.: `npm run build && npm start` or using docker image
3. Restart auction on kovan using frontend
3. Restart auction on goerli using frontend
4. Check the logs for the tweet message and its url

Using the `Dockerfile`:
Expand Down
10 changes: 0 additions & 10 deletions core/src/network.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,6 @@ const SUPPORTED_NETWORKS: NetworkConfig[] = [
etherscanUrl: 'https://etherscan.io',
isFork: false,
},
{
chainId: '0x2a',
type: 'kovan',
title: 'Kovan',
gasPrice: 2000000000,
url: '',
etherscanUrl: 'https://kovan.etherscan.io',
isFork: false,
},
{
chainId: '0x5',
type: 'goerli',
Expand Down Expand Up @@ -82,7 +73,6 @@ export const setNetwork = function (networkConfig: NetworkConfig): void {
const NETWORK_TITLES: Record<string, string | undefined> = {
// full list can be found on https://chainlist.org
'0x1': 'mainnet',
'0x2a': 'kovan',
'0x5': 'goerli',
'0x539': 'custom',
};
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ storiesOf('Modals/ChangeWalletNetworkModal', module).add('Default', () => ({
...common,
template: `<ChangeWalletNetworkModal
invalid-network="invalid-network"
page-network="kovan"
page-network="mainnet"
@setPageNetwork="setPageNetwork"
@fixWalletNetwork="fixWalletNetwork"
/>`,
Expand Down
2 changes: 1 addition & 1 deletion frontend/components/wallet/WalletModal.stories.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ const common = {
isWithdrawingAllowed: true,
walletAddress: faker.finance.ethereumAddress(),
isWalletLoading: false,
network: 'kovan',
network: 'mainnet',
}),
methods: {
refresh: action('refresh'),
Expand Down
2 changes: 1 addition & 1 deletion frontend/helpers/generateFakeCompensationAuction.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { CompensationAuctionBase, CompensationAuctionTransactionFees } from 'auc
import faker from 'faker';
import BigNumber from 'bignumber.js';

const NETWORKS = ['mainnet', 'kovan', 'goerli'];
const NETWORKS = ['mainnet', 'goerli'];

export const generateFakeCompensationAuctionBase = function (network?: string): CompensationAuctionBase {
return {
Expand Down
14 changes: 7 additions & 7 deletions notification-service/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ Note: env variables are accessible via the `secret` command under `auction-ui/${

- `INFURA_PROJECT_ID`: (required) [infura](https://infura.io/) project id (can be found in: dashboard -> ethereum ->
- `ETHERSCAN_API_KEY`: (required) [Etherscan API Key](https://docs.etherscan.io/getting-started/viewing-api-usage-statistics), which is used to automatically download ABIs
- `ETHEREUM_NETWORK`: (optional, default `kovan`) – internal network name on which the bot poll for auctions. Available
- `ETHEREUM_NETWORK`: (optional, default `mainnet`) – internal network name on which the bot poll for auctions.
- `SMTP_*`: (optional, required for email usage) - SMTP data for the service to send emails
- `SMTP_HOST`: (required) - SMTP host address
- `SMTP_PORT`: (optional) - SMTP port. Defaults to `465`
Expand All @@ -54,7 +54,7 @@ You can find examples below:
{
"receiver": "[email protected]",
"type": "email",
"subscriptions": ["MCD_DAI_Transfer", "ChainLogUpdateAddress"]
"subscriptions": ["ChainLogUpdateAddress"]
}
```
Please make sure to include the required [`Environment variables`](#environment-variables).
Expand All @@ -64,7 +64,7 @@ Please make sure to include the required [`Environment variables`](#environment-
{
"receiver": "https://discord.com/api/webhooks/YOUR_WEBHOOK_ADDRESS",
"type": "discord",
"subscriptions": ["MCD_DAI_Transfer", "ChainLogUpdateAddress"]
"subscriptions": ["ChainLogUpdateAddress"]
}
````
Please provide a [Discord Webhook URL](https://support.discord.com/hc/en-us/articles/228383668-Intro-to-Webhooks) to which we can send updates.
Expand Down Expand Up @@ -93,10 +93,10 @@ export const SUBSCRIPTIONS: EventSubscription[] = [
address: '0xdA0Ab1e0017DEbCd72Be8599041a2aa3bA7e740F',
eventName: 'UpdateAddress',
formatData: (event, formatEtherscanLink) => {
return `> From: [${event.args.src}](${formatEtherscanLink('address', event.args.src)})<br />
> To: [${event.args.dst}](${formatEtherscanLink('address', event.args.src)})`;
}
}
return `> Key: ${ethers.utils.formatBytes32String(event.args.key)}<br />
> Address: [${event.args.addr}](${formatEtherscanLink('address', event.args.addr)})`;
},
},
]
```

Expand Down
5 changes: 0 additions & 5 deletions notification-service/src/constants/NETWORKS.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,6 @@ export const NETWORKS: Record<string, { network: string; etherscanURL: string; e
etherscanURL: 'https://ropsten.etherscan.io',
etherscanAPI: 'https://api-ropsten.etherscan.io',
},
kovan: {
network: 'kovan',
etherscanURL: 'https://kovan.etherscan.io',
etherscanAPI: 'https://api-kovan.etherscan.io',
},
rinkeby: {
network: 'rinkeby',
etherscanURL: 'https://rinkeby.etherscan.io',
Expand Down
9 changes: 4 additions & 5 deletions notification-service/src/constants/SUBSCRIPTIONS.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,11 @@ export const SUBSCRIPTIONS: EventSubscription[] = [
},
},
{
id: 'MCD_DAI_Transfer',
address: '0x4f96fe3b7a6cf9725f59d353f723c1bdb64ca6aa',
id: 'MCD_DAI',
address: '0xc02aaa39b223fe8d0a0e5c4f27ead9083c756cc2',
eventName: 'Transfer',
formatData: (event, formatEtherscanLink) => {
return `> From: [${event.args.src}](${formatEtherscanLink('address', event.args.src)})<br />
> To: [${event.args.dst}](${formatEtherscanLink('address', event.args.dst)})`;
formatData: event => {
return `This is a test transaction ${event}`;
},
},
];
Expand Down
2 changes: 1 addition & 1 deletion notification-service/src/variables.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
export const INFURA_PROJECT_ID = process.env.INFURA_PROJECT_ID;
export const ETHERSCAN_API_KEY = process.env.ETHERSCAN_API_KEY;
export const ETHEREUM_NETWORK = process.env.ETHEREUM_NETWORK || 'kovan';
export const ETHEREUM_NETWORK = process.env.ETHEREUM_NETWORK || 'mainnet';

export const SMTP_HOST = process.env.SMTP_HOST;
export const SMTP_PORT = parseInt(process.env.SMTP_PORT || '465');
Expand Down

0 comments on commit b398c5b

Please sign in to comment.