feat: add support for context.Context in Retry
#5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Existing function `Retry` is maintained with the same API to preserve backwards compatibility. New function `RetryWithContext` accepts a context and delivers it to the retryable function. Each retry attempt can be limited by timeout (via context, `WithAttemptTimeout`). Garbage-collected channel `C` which wasn't used. Replaced stop channel delivery with `close(ch)` to avoid having a channel with a single entry. Removed `time.After()` as it leaks the object until timer fires. Fixes siderolabs#2 Signed-off-by: Andrey Smirnov <[email protected]>
|
/approve |
andrewrynhard
approved these changes
Jan 18, 2021
Unix4ever
approved these changes
Jan 18, 2021
AlekSi
reviewed
Jan 18, 2021
| @@ -138,7 +146,7 @@ func (t ticker) StopChan() <-chan struct{} { | |||
| } | |||
|
|
|||
| func (t ticker) Stop() { | |||
| t.s <- struct{}{} | |||
| close(t.s) | |||
There was a problem hiding this comment.
I wonder if that should be wrapped with sync.Once to allow several Stop() calls like time.Ticker allows
There was a problem hiding this comment.
I think sync.Once is pretty heavyweight, I don't think we even ever used .Stop() in our codebase (never saw it myself, but still could be used somewhere).
Probably even .Stop() is no longer required given that we have a context which can be canceled (but that is not backwards compatible).
There was a problem hiding this comment.
so, I would rather not do it unless we see a big use case for .Stop()
AlekSi
approved these changes
Jan 18, 2021
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing function
Retryis maintained with the same API to preservebackwards compatibility.
New function
RetryWithContextaccepts a context and delivers it to theretryable function. Each retry attempt can be limited by timeout (via
context,
WithAttemptTimeout).Garbage-collected channel
Cwhich wasn't used.Replaced stop channel delivery with
close(ch)to avoid having achannel with a single entry.
Removed
time.After()as it leaks the object until timer fires.Fixes #2
Signed-off-by: Andrey Smirnov [email protected]