add support for context.Context #2
Assignees
Labels
enhancement
New feature or request
Comments
smira
added a commit
to smira/go-retry
that referenced
this issue
Jan 18, 2021
Existing function `Retry` is maintained with the same API to preserve backwards compatibility. New function `RetryWithContext` accepts a context and delivers it to the retryable function. Each retry attempt can be limited by timeout (via context, `WithAttemptTimeout`). Garbage-collected channel `C` which wasn't used. Replaced stop channel delivery with `close(ch)` to avoid having a channel with a single entry. Removed `time.After()` as it leaks the object until timer fires. Fixes siderolabs#2 Signed-off-by: Andrey Smirnov <[email protected]>
talos-bot
pushed a commit
that referenced
this issue
Jan 19, 2021
Existing function `Retry` is maintained with the same API to preserve backwards compatibility. New function `RetryWithContext` accepts a context and delivers it to the retryable function. Each retry attempt can be limited by timeout (via context, `WithAttemptTimeout`). Garbage-collected channel `C` which wasn't used. Replaced stop channel delivery with `close(ch)` to avoid having a channel with a single entry. Removed `time.After()` as it leaks the object until timer fires. Fixes #2 Signed-off-by: Andrey Smirnov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Retry should respect context cancellation and abort on context cancel; timeout might be implemented via the context
The text was updated successfully, but these errors were encountered: