Add Go 1.4 support. #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids the need for bypass.
They are kept on an experimental branch for potential future testing, but the current bypass should be stable and passes all tests.
/cc @davecgh This may change if I later play with the bypass_alt approach and find it works better. However, staying with go-spew's version means it is better tested. At the end of the day, I would like a single (exported) best solution for bypass (if it's possible for it to cover all use cases and needs).
Apply the change from davecgh/go-spew@83f84dc.
|
Just in time for the release of Go 1.4 Release Candidate 1! :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Go 1.4, while maintaining support for 1.3.
It also exports
UnsafeReflectValuefunctionality in a newbypasspackage. This way, that functionality doesn't need to be duplicated in another package (previously here) and is easier to maintain.