Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install Process #6

Closed
JustinRyanH opened this issue Nov 14, 2014 · 5 comments
Closed

Install Process #6

JustinRyanH opened this issue Nov 14, 2014 · 5 comments

Comments

@JustinRyanH
Copy link

I get a "cannot find package" error went I try to get.

imports github.com/shurcooL/go-goon/bypass: cannot find package "github.com/shurcooL/go-goon/bypass" in any of:

when I got to github.com/shurcooL/go-goon/ I don't really see anything that would fit the bypass description.
@dmitshur
Copy link
Member

Hi, thanks for giving Conception-go a try and reporting this issue.

This is a temporary issue that I will resolve soon. Until then, if you go in the go-goon repo, you can use the go14_support branch which has the bypass package. See https://github.com/shurcooL/go-goon/tree/go14_support.

Let me know if you run into anything else. I will update the README to make the installation process smoother in the future.

@dmitshur
Copy link
Member

Sorry, there's another uncommitted dependency (because the code organization isn't quite finished), so fixing bypass alone isn't enough.

I will fix this tonight and ensure Conception-go is go gettable.

dmitshur referenced this issue in davecgh/go-spew Nov 15, 2014
@davecgh
Add logic to deal with reflect pkg changes on tip.
1288542 
This commit adds logic to gracefully handle the new internal reflect.Value
structure on tip as of golang commit 82f48826c6c7 as well as the internal
reflect.Value flag bit changes as of golang commit 90a7c3c86944.

It accomplishes this by doing some inspection at init time and choosing
the appropriate offsets and flag positions accordingly.  There was some
previous logic which dealt with a similar issue for golang commit
ecccf07e7f9d.  However, since the more recent commits essentially reverted
the change and also modify the flag bit positions, it made more sense to
rework the detection logic.  In particular, the new logic examines the
size of the reflect.Value struct to determine the difference and extracts
the kind from the flags to determine if the flags have been changed.

As a result, this commit allows spew to work properly with tip all the
back to Go 1.0.
@dmitshur
Copy link
Member

Okay, I've resolved one of two blockers:

One more to go.

@dmitshur
Copy link
Member

Sorry this took so long, but it should be fixed and you should able to install Conception-go as described in the README.

Please let me know if the issue is fixed and any other thoughts you may have.

@dmitshur
Copy link
Member

I've added a Travis build check so this should happen less in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JustinRyanH @dmitshur