Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deprecate references to discourse #583

Merged
merged 3 commits into from
Oct 6, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/1-bug-report.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ body:
Before you make a bug report, please check our existing resources to see if it has already been discussed/reported:
- [Reported bugs](https://github.com/shrinerb/shrine/issues)
- [GitHub Discussions](https://github.com/shrinerb/shrine/discussions/)
- [Shrine Discourse (A Question / Answer Forum)](https://discourse.shrinerb.com/)
- [Discourse](https://discourse.shrinerb.com/) (alternative forum)

- type: textarea
attributes:
Expand Down
3 changes: 2 additions & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Issue Guidelines
================

1. Issues should only be created for things that are definitely bugs. If you
are not sure that the behavior is a bug, ask about it on the [forum]. Otherwise Github gets overwhelmed with issues and it is very difficult for the maintainers to manage.
are not sure that the behavior is a bug, ask about it on the [forum] or on [Github Discussions]. Otherwise Github gets overwhelmed with issues and it is very difficult for the maintainers to manage.

2. If you are sure it is a bug, then post a complete description of the issue,
the simplest possible [self-contained example] showing the problem (please do review the link), and the full backtrace of any exception.
Expand Down Expand Up @@ -59,6 +59,7 @@ Code of Conduct
Everyone interacting in the Shrine project’s codebases, issue trackers, chat
rooms, and mailing lists is expected to follow the [Shrine code of conduct].

[Github Discussions]: https://github.com/shrinerb/shrine/discussions
[forum]: https://discourse.shrinerb.com
[Shrine code of conduct]: https://github.com/shrinerb/shrine/blob/master/CODE_OF_CONDUCT.md
[libmagic]: https://github.com/threatstack/libmagic
Expand Down
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ guide]**.
| Website & Documentation | [shrinerb.com](https://shrinerb.com) |
| Demo code | [Roda][roda demo] / [Rails][rails demo] |
| Wiki | [github.com/shrinerb/shrine/wiki](https://github.com/shrinerb/shrine/wiki) |
| Help (Preferred) | [Github Discussions](https://github.com/shrinerb/shrine/discussions) |
| Help & Discussion | [discourse.shrinerb.com](https://discourse.shrinerb.com) |

## Setup
Expand Down
1 change: 1 addition & 0 deletions SELF_CONTAINED_EXAMPLE.md
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,7 @@ If you would like to debug or step through Shrine's code using the above templat

8. Run `ruby template_name.rb`.

[Github Discussions]: https://github.com/shrinerb/shrine/discussions
[forum]: https://discourse.shrinerb.com
[Shrine code of conduct]: https://github.com/shrinerb/shrine/blob/master/CODE_OF_CONDUCT.md
[libmagic]: https://github.com/threatstack/libmagic
Expand Down
12 changes: 9 additions & 3 deletions website/core/Footer.js
Original file line number Diff line number Diff line change
Expand Up @@ -31,19 +31,25 @@ class Footer extends React.Component {
<a href={`${config.githubUrl}/blob/master/CONTRIBUTING.md#readme`}>Contributing</a>
</div>
<div>
<h5>Community</h5>
<h5>Help</h5>
<a
href={config.discourseUrl}
href={config.githubDiscussionsUrl}
target="_blank"
rel="noreferrer noopener">
Discourse
Github Discussions
</a>
<a
href={config.stackOverflowUrl}
target="_blank"
rel="noreferrer noopener">
Stack Overflow
</a>
<a
href={config.discourseUrl}
target="_blank"
rel="noreferrer noopener">
Discourse
</a>
</div>
<div>
<h5>More</h5>
Expand Down
2 changes: 1 addition & 1 deletion website/i18n/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -364,7 +364,7 @@
"Guides": "Guides",
"Plugins": "Plugins",
"External": "External",
"Discourse": "Discourse",
"Help": "Help",
"GitHub": "GitHub",
"Wiki": "Wiki"
},
Expand Down
3 changes: 2 additions & 1 deletion website/siteConfig.js
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ const siteConfig = {
{doc: 'getting-started', label: 'Guides'},
{doc: 'plugins/activerecord', label: 'Plugins'},
{doc: 'external/extensions', label: 'External'},
{href: 'https://discourse.shrinerb.com', label: 'Discourse', external: true},
{href: 'https://github.com/shrinerb/shrine/discussions', label: 'Help', external: true},
{href: 'https://github.com/shrinerb/shrine', label: 'GitHub', external: true},
{href: 'https://github.com/shrinerb/shrine/wiki', label: 'Wiki', external: true},
],
Expand Down Expand Up @@ -109,6 +109,7 @@ const siteConfig = {
editUrl: 'https://github.com/shrinerb/shrine/edit/master/doc/',
blogUrl: 'https://janko.io',
discourseUrl: 'https://discourse.shrinerb.com',
githubDiscussionsUrl: 'https://github.com/shrinerb/shrine/discussions',
stackOverflowUrl: 'https://stackoverflow.com/questions/tagged/shrine',

twitterUsername: 'shrine_rb',
Expand Down