Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on UnregisterBroker #1820

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Conversation

rukai
Copy link
Member

@rukai rukai commented Nov 18, 2024

UnregisterBroker is a replacement for ControlledShutdown.
So the same reasoning as #1791 applies here.

Copy link

codspeed-hq bot commented Nov 18, 2024

CodSpeed Performance Report

Merging #1820 will not alter performance

Comparing rukai:error_on_unregister_broker (0f955eb) with main (73ac04c)

Summary

✅ 38 untouched benchmarks

@rukai rukai marked this pull request as ready for review November 18, 2024 02:56
@rukai rukai enabled auto-merge (squash) November 18, 2024 23:39
@rukai rukai merged commit 3f76b54 into shotover:main Nov 19, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants