Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KafkaSinkCluster return error on ControlledShutdown request #1791

Merged
merged 2 commits into from
Nov 1, 2024

Conversation

rukai
Copy link
Member

@rukai rukai commented Oct 30, 2024

Refer to the reasoning in the comment

Copy link

codspeed-hq bot commented Oct 30, 2024

CodSpeed Performance Report

Merging #1791 will not alter performance

Comparing rukai:controlled_shutdown (225048d) with main (372186d)

Summary

✅ 38 untouched benchmarks

@rukai rukai enabled auto-merge (squash) November 1, 2024 01:47
@rukai rukai merged commit 8d374bc into shotover:main Nov 1, 2024
41 checks passed
@rukai rukai mentioned this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants